Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1746593002: Subzero: Build sandboxed translators for the browser. (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Build sandboxed translators for the browser. Along with the nexe equivalents of pnacl-sz, also build the browser-integrated versions that can be dropped in as replacements. Note that these are not exact replacements, as they likely support all targets. In "make presubmit", instead build sandboxed translators in DEBUG=1 mode, so they can build in parallel with the assembler unit tests. Add a "make bloat-sb" target that does the "make bloat" equivalent for the sandboxed translators. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c4ed549e9ec3936ed49cecfcd7c16361aa930ae9

Patch Set 1 #

Patch Set 2 : Reduce most repetition over nexe files #

Patch Set 3 : Simplify and fix #

Patch Set 4 : Simple pnacl-finalize rule #

Patch Set 5 : More precise use of --pnacl-disable-abi-check #

Patch Set 6 : Fix location of json files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -24 lines) Patch
M Makefile.standalone View 1 2 3 4 5 15 chunks +41 lines, -20 lines 0 comments Download
A + bloat/pnacl-sz.x8632.nexe.bloat.html View 1 chunk +1 line, -1 line 0 comments Download
A + bloat/pnacl-sz.x8664.nexe.bloat.html View 1 chunk +1 line, -1 line 0 comments Download
A + bloat/pnacl_public_x86_32_pnacl_sz_nexe.bloat.html View 1 chunk +1 line, -1 line 0 comments Download
A + bloat/pnacl_public_x86_64_pnacl_sz_nexe.bloat.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
It would be nice to refactor the 5 nearly-identical .html files, but html inclusion seems ...
4 years, 9 months ago (2016-02-28 05:28:41 UTC) #3
John
lgtm
4 years, 9 months ago (2016-02-29 15:00:51 UTC) #4
Jim Stichnoth
4 years, 9 months ago (2016-02-29 17:16:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
c4ed549e9ec3936ed49cecfcd7c16361aa930ae9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698