Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: components/autofill/content/browser/DEPS

Issue 17465003: Fix most tests in //components/autofill/content to not depend on //chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove IO thread, seems not needed. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 include_rules = [ 1 include_rules = [
2 "+components/webdata/common", 2 "+components/webdata/common",
3 "+content/public/browser", 3 "+content/public/browser",
4 "+crypto/random.h", 4 "+crypto/random.h",
5 "+google_apis/gaia", 5 "+google_apis/gaia",
6 "+google_apis/google_api_keys.h", 6 "+google_apis/google_api_keys.h",
7 "+gpu/config/gpu_info.h", 7 "+gpu/config/gpu_info.h",
8 "+net", 8 "+net",
9 "+sql", 9 "+sql",
10 "+third_party/libjingle", 10 "+third_party/libjingle",
11 "+third_party/libphonenumber", # For phone number i18n. 11 "+third_party/libphonenumber", # For phone number i18n.
12 "+webkit/plugins/webplugininfo.h", 12 "+webkit/plugins/webplugininfo.h",
13 13
14 # TODO(akalin): Remove this dependency. 14 # TODO(akalin): Remove this dependency.
15 "!sync/util/data_encryption_win.h", 15 "!sync/util/data_encryption_win.h",
16 ] 16 ]
17 17
18 specific_include_rules = { 18 specific_include_rules = {
19 '.*_[a-z]*test\.cc': [ 19 '.*_[a-z]*test\.cc': [
20 "+content/public/test", 20 "+content/public/test",
21 ],
21 22
22 # TODO(joi, kaiwang): Bring this list to zero. 23 # TODO(joi): Removing these dependencies needs to wait until some
23 # 24 # other things (AutofillWebData::FromBrowserContext and a few other
24 # Do not add to the list of temporarily-allowed dependencies below, 25 # things) move out of being built in //chrome. If we break the
25 # and please do not introduce more #includes of these files. 26 # dependency on ChromeRenderViewHostTestHarness now (by switching to
26 "!chrome/browser/autofill/autofill_cc_infobar_delegate.h", 27 # content::RenderViewHostTestHarness) but leave the test running in
27 "!chrome/browser/autofill/personal_data_manager_factory.h", 28 # the 'unit_tests' target, it will fail at runtime trying to cast a
28 "!chrome/browser/password_manager/encryptor.h", 29 # plain BrowserContext to a Profile. If on the other hand we move it
29 "!chrome/browser/password_manager/password_manager.h", 30 # to the 'components_unittests' target, it will at this point fail
30 "!chrome/browser/password_manager/password_manager_delegate_impl.h", 31 # to build due to a few link-time dependencies.
31 "!chrome/browser/profiles/profile.h", 32 'autocheckout_manager_unittest.cc': [
32 "!chrome/browser/sync/profile_sync_service.h", 33 "+chrome/test/base/chrome_render_view_host_test_harness.h",
Paweł Hajdan Jr. 2013/06/19 23:00:04 Why not "!" ?
Jói 2013/06/21 13:13:23 Fixed to use ! here and line below.
33 "!chrome/browser/sync/profile_sync_service_factory.h", 34 "+chrome/test/base/testing_profile.h",
34 "!chrome/browser/translate/translate_infobar_delegate.h",
35 "!chrome/browser/translate/translate_manager.h",
36 "!chrome/browser/ui/autofill/tab_autofill_manager_delegate.h",
37 "!chrome/browser/ui/browser.h",
38 "!chrome/browser/ui/browser_tabstrip.h",
39 "!chrome/browser/ui/browser_window.h",
40 "!chrome/browser/ui/tabs/tab_strip_model.h",
41 "!chrome/browser/webdata/web_data_service.h",
42 "!chrome/browser/webdata/web_data_service_factory.h",
43 "!chrome/browser/webdata/web_data_service_test_util.h",
44 "!chrome/test/base",
45 ], 35 ],
46 } 36 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698