[sqlite] Backport icuCaseFunc16 patch from SQLite.

[sqlite] Backport icuCaseFunc16 patch from SQLite.

Original Chromium CL at https://codereview.chromium.org/1704103002

"Fix sqlite3's handling of casemapping result 3 times as long as
input"

SQLite interpretation at
http://www.sqlite.org/src/info/b8dc1b9f5d413000

"Fix a potential buffer overflow in the ICU upper() function."

BUG=586079, 594478
TEST=https://jsfiddle.net/ym2nuaj2/3/ (from bug 594478 comment 1)

[Scott Hess - ex-Googler, 2016-02-26 23:28:44]

shess@chromium.org changed reviewers:
+ jshin@chromium.org

[Scott Hess - ex-Googler, 2016-02-26 23:28:44]

Backport their other fix.  This is not technically dependent on the other
patches, I just didn't want to figure out whether the amalgamation would cause
problems, so if this is +1 but you want to hold off on the other one, just let
me know and I can reorder things.

[Scott Hess - ex-Googler, 2016-03-02 18:38:57]

On 2016/02/26 23:28:44, Scott Hess wrote:
> Backport their other fix.  This is not technically dependent on the other
> patches, I just didn't want to figure out whether the amalgamation would cause
> problems, so if this is +1 but you want to hold off on the other one, just let
> me know and I can reorder things.

Just in case - since this one is coming from SQLite to Chromium, and replaces
your version of the fix, I was hoping you could eyeball it to see if you're
happy with it (as opposed to the TBR I used when converting your earlier changes
to patches).  icu.c and icu.test are the only important bits, the sqlite3.c
change and the patches are just rephrasing of icu.c changes.  Thanks.

[jungshik at Google, 2016-03-11 21:39:42]

LGTM
Sorry for the late reply.

[jungshik at Google, 2016-04-05 18:45:18]

Scott, would you land this CL?  The upstream patch fixes a case I overlooked
(when the input is an empty string ("")). 

That's https://bugs.chromium.org/p/chromium/issues/detail?id=594478  (it's a M50
stable-blocker).

[jungshik at Google, 2016-04-05 19:00:26]

Description was changed from

==========
[sqlite] Backport icuCaseFunc16 patch from SQLite.

Original Chromium CL at https://codereview.chromium.org/1704103002

"Fix sqlite3's handling of casemapping result 3 times as long as
input"

SQLite interpretation at
http://www.sqlite.org/src/info/b8dc1b9f5d413000

"Fix a potential buffer overflow in the ICU upper() function."

BUG=586079
==========

to

==========
[sqlite] Backport icuCaseFunc16 patch from SQLite.

Original Chromium CL at https://codereview.chromium.org/1704103002

"Fix sqlite3's handling of casemapping result 3 times as long as
input"

SQLite interpretation at
http://www.sqlite.org/src/info/b8dc1b9f5d413000

"Fix a potential buffer overflow in the ICU upper() function."

BUG=586079,594478
TEST=https://jsfiddle.net/ym2nuaj2/3/ (from bug 594478 comment 1)
==========

[jungshik at Google, 2016-04-05 21:02:33]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2016-04-05 21:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 21:03:00]

This CL has an open dependency (Issue 1742693003 Patch 1). Please resolve the
dependency and try again.