content/shell/browser/layout_test/blink_test_controller.cc - Issue 1746393002: Quit BlinkTestRunner::TestFinished early if main frame is not local.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/blink_test_controller.cc

Issue 1746393002: Quit BlinkTestRunner::TestFinished early if main frame is not local. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reenable-tests-fixed-by-alex

Patch Set: Rebasing... Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.h ('k') | content/shell/browser/layout_test/notify_done_forwarder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/blink_test_controller.cc

diff --git a/content/shell/browser/layout_test/blink_test_controller.cc b/content/shell/browser/layout_test/blink_test_controller.cc

index 3793d4c1673391cade760555ab69c49f0c33ab81..554159fa58d2a29c1253aef43cfffd8d91a3c4d3 100644

--- a/content/shell/browser/layout_test/blink_test_controller.cc

+++ b/content/shell/browser/layout_test/blink_test_controller.cc

@@ -374,7 +374,7 @@ void BlinkTestController::OpenURL(const GURL& url) {

gfx::Size());

}

-void BlinkTestController::TestFinishedInSecondaryWindow() {

+void BlinkTestController::TestFinishedInSecondaryRenderer() {

RenderViewHost* render_view_host =

main_window_->web_contents()->GetRenderViewHost();

render_view_host->Send(