[js-perf-test] add microbenchmarks for Object.values(), Object.entries()

test/js-perf-test/Object/values.js

Index: test/js-perf-test/Object/values.js
diff --git a/test/js-perf-test/Object/values.js b/test/js-perf-test/Object/values.js
new file mode 100644
index 0000000000000000000000000000000000000000..cc483d07982dfa3d515636e581ee16cb58a2b8b8
--- /dev/null
+++ b/test/js-perf-test/Object/values.js
@@ -0,0 +1,270 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+new BenchmarkSuite('Values', [1000], [
+  new Benchmark('Basic', false, false, 0, Basic, BasicSetup, BasicTearDown),
+  new Benchmark('BasicMegamorphic', false, false, 0, BasicMegamorphic,
+                BasicMegamorphicSetup, BasicMegamorphicTearDown)
+]);
+
+var object;
+var symbol1;
+var symbol2;
+var result;
+
+function Basic() {
+  result = Object.values(object);
+}
+
+
+function BasicSetup() {
+  result = undefined;
+  symbol1 = Symbol('test');
+  object = { a: 10 };
+  object[26.0] = 'third';
+  object.b = 72;
+  object[symbol1] = 'TEST';
+  Object.defineProperty(object, 'not-enumerable', {
+      enumerable: false, value: 'nope', writable: true, configurable: true });
+}
+
+
+function BasicTearDown() {
+  return result.length === 3 && result[0] === 10 && result[1] === 'third' &&
+         result[2] === 72;
+}
+
+// ----------------------------------------------------------------------------
+
+function BasicMegamorphic() {
+  result = [
+    Object.values(object[0]), Object.values(object[1]), Object.values(object[2]),
+    Object.values(object[3]), Object.values(object[4]), Object.values(object[5]),
+    Object.values(object[6]), Object.values(object[7]), Object.values(object[8]),
+    Object.values(object[9]), Object.values(object[10]), Object.values(object[11]),
+    Object.values(object[12]), Object.values(object[13]), Object.values(object[14]),
+    Object.values(object[15]), Object.values(object[16]), Object.values(object[17]),
+    Object.values(object[18]), Object.values(object[19]), Object.values(object[20]),
+    Object.values(object[21]), Object.values(object[22]), Object.values(object[23]),
+    Object.values(object[24]),
+    Object.values(object[0]), Object.values(object[1]), Object.values(object[2]),
+    Object.values(object[3]), Object.values(object[4]), Object.values(object[5]),
+    Object.values(object[6]), Object.values(object[7]), Object.values(object[8]),
+    Object.values(object[9]), Object.values(object[10]), Object.values(object[11]),
+    Object.values(object[12]), Object.values(object[13]), Object.values(object[14]),
+    Object.values(object[15]), Object.values(object[16]), Object.values(object[17]),
+    Object.values(object[18]), Object.values(object[19]), Object.values(object[20]),
+    Object.values(object[21]), Object.values(object[22]), Object.values(object[23]),
+    Object.values(object[24]),
+    Object.values(object[0]), Object.values(object[1]), Object.values(object[2]),
+    Object.values(object[3]), Object.values(object[4]), Object.values(object[5]),
+    Object.values(object[6]), Object.values(object[7]), Object.values(object[8]),
+    Object.values(object[9]), Object.values(object[10]), Object.values(object[11]),
+    Object.values(object[12]), Object.values(object[13]), Object.values(object[14]),
+    Object.values(object[15]), Object.values(object[16]), Object.values(object[17]),
+    Object.values(object[18]), Object.values(object[19]), Object.values(object[20]),
+    Object.values(object[21]), Object.values(object[22]), Object.values(object[23]),
+    Object.values(object[24]),
+    Object.values(object[0]), Object.values(object[1]), Object.values(object[2]),
+    Object.values(object[3]), Object.values(object[4]), Object.values(object[5]),
+    Object.values(object[6]), Object.values(object[7]), Object.values(object[8]),
+    Object.values(object[9]), Object.values(object[10]), Object.values(object[11]),
+    Object.values(object[12]), Object.values(object[13]), Object.values(object[14]),
+    Object.values(object[15]), Object.values(object[16]), Object.values(object[17]),
+    Object.values(object[18]), Object.values(object[19]), Object.values(object[20]),
+    Object.values(object[21]), Object.values(object[22]), Object.values(object[23]),
+    Object.values(object[24]),

[Camillo Bruni, 2016/03/04 17:15:25]

How about something more sustainable:

var length = object.length;
for (var i = 0; i<length; i++) {
 Object.values(object[i]))
}

I don't think we gain much value by tracking the results here.

[caitp (gmail), 2016/03/04 17:19:30]

Are you sure LICM won't just turn this into a "no-op" test, particularly in the
lodash case? That's why the results are verified

+  ];
+}
+
+
+function BasicMegamorphicSetup() {
+  symbol1 = Symbol('megamorphicTest');
+  symbol2 = Symbol('megamorphicTest2');
+  object = [
+    { a: 1, [symbol1]: 'ignored' },
+    { q: 'q', [symbol1]: 'ignored', zz: '2' },
+    { precedence: 13, operator: '*', lhs: 4.7, rhs: 5.9 },
+    { name: 'Wiggins', occupation: 'woofer', age: 4, breed: 'papillon' },
+    { author: 'Ted Chiang', title: 'The Lifecycle Of Software Objects',
+      isbn: '978-1-59606-317-4' },
+    { lemon_zest: true, [symbol1]: 'ignored', },
+    { elite_status: 'zerpaderp', airline: 'Bambasherp Airways' },
+    { card_no: 'xxxx-xxxx-xxxx-xxxx', exp_date: 'mm/dd',
+      card_holder: 'Zapp Brannigan', authorized_date: '01/02/3066' },
+    { [symbol1]: 'ignored', a: 49 },
+    { a: 64, [symbol1]: 'ignored', b: 45 },
+    { a: 64, [symbol1]: 'ignored', c: 72 },
+    { operator: '>>>', lhs: 0x8000, rhs: 2, precedence: 11 },
+    { [symbol1]: 'ignored', lemon_zest: false, basil: true },
+    Object.defineProperty({ a: 64, [symbol1]: 'ignored', b: 45 }, '_hidden', {
+      get() { return 'ignored!' },
+      set() { throw new Error('NO!'); },
+      enumerable: false, configurable: false
+    }),
+    Object.defineProperty({ exp_date: 'mm/dd', card_no: 'xxx-xxx-xxx-xxx',
+                            card_holder: 'Zapp Brannigan' }, 'declined', {
+      value: '01/02/3066',
+      enumerable: true,
+      configurable: false,
+      writable: false
+    }),
+    { item: 'potato', qty: '6.7kg', date: '02/13/1947' },
+    { date: '02/27/1948', item: 'scallop', qty: '3.4kg' },
+    { qty: '448g', item: 'peppercorn', date: '03/17/1948', delivery: true },
+    { number: 26, name: 'Taft, William Howard', sworn: '03/04/1909' },
+    { name: 'Roosevelt, Franklin D', sworn: '03/04/1933', number: 32 },
+    { [symbol2]: 'symbol2', [symbol1]: 'symbol1', token: 'collected' },
+    { 0: 44, 1: 88, a: 49, b: 68 },
+    { 44: 1, a: 49, c: 71 },
+    { count: 984, year: 2016, bugs: 'fixed' },
+    { cavities: 0, fillers: 0, cracks: 0, color: 'pristine', flosses: 'daily' }
+  ];
+}
+
+
+function BasicMegamorphicTearDown() {
+  // TODO(caitp): move these result verifier utilities (from mjsunit.js) to
+  // base.js? Or just load mjsunit.js?
+  var ObjectPrototypeToString = Object.prototype.toString;
+  var NumberPrototypeValueOf = Number.prototype.valueOf;
+  var BooleanPrototypeValueOf = Boolean.prototype.valueOf;
+  var StringPrototypeValueOf = String.prototype.valueOf;
+  var DatePrototypeValueOf = Date.prototype.valueOf;
+  var RegExpPrototypeToString = RegExp.prototype.toString;
+  var ArrayPrototypeMap = Array.prototype.map;
+  var ArrayPrototypeJoin = Array.prototype.join;
+
+  function classOf(object) {
+    // Argument must not be null or undefined.
+    var string = ObjectPrototypeToString.call(object);
+    // String has format [object <ClassName>].
+    return string.substring(8, string.length - 1);
+  }
+
+
+  function ValueOf(value) {
+    switch (classOf(value)) {
+      case "Number":
+        return NumberPrototypeValueOf.call(value);
+      case "String":
+        return StringPrototypeValueOf.call(value);
+      case "Boolean":
+        return BooleanPrototypeValueOf.call(value);
+      case "Date":
+        return DatePrototypeValueOf.call(value);
+      default:
+        return value;
+    }
+  }
+
+  function deepObjectEquals(a, b) {
+    var aProps = Object.keys(a);
+    aProps.sort();
+    var bProps = Object.keys(b);
+    bProps.sort();
+    if (!deepEquals(aProps, bProps)) {
+      return false;
+    }
+    for (var i = 0; i < aProps.length; i++) {
+      if (!deepEquals(a[aProps[i]], b[aProps[i]])) {
+        return false;
+      }
+    }
+    return true;
+  }
+
+
+  function deepEquals(a, b) {
+    if (a === b) {
+      // Check for -0.
+      if (a === 0) return (1 / a) === (1 / b);
+      return true;
+    }
+    if (typeof a !== typeof b) return false;
+    if (typeof a === "number") return isNaN(a) && isNaN(b);
+    if (typeof a !== "object" && typeof a !== "function") return false;
+    // Neither a nor b is primitive.
+    var objectClass = classOf(a);
+    if (objectClass !== classOf(b)) return false;
+    if (objectClass === "RegExp") {
+      // For RegExp, just compare pattern and flags using its toString.
+      return RegExpPrototypeToString.call(a) ===
+             RegExpPrototypeToString.call(b);
+    }
+    // Functions are only identical to themselves.
+    if (objectClass === "Function") return false;
+    if (objectClass === "Array") {
+      var elementCount = 0;
+      if (a.length !== b.length) {
+        return false;
+      }
+      for (var i = 0; i < a.length; i++) {
+        if (!deepEquals(a[i], b[i])) return false;
+      }
+      return true;
+    }
+    if (objectClass === "String" || objectClass === "Number" ||
+      objectClass === "Boolean" || objectClass === "Date") {
+      if (ValueOf(a) !== ValueOf(b)) return false;
+    }
+    return deepObjectEquals(a, b);
+  }
+
+  var expected = [
+    [1], ['q', '2'], [13, '*', 4.7, 5.9], ['Wiggins', 'woofer', 4, 'papillon'],
+    ['Ted Chiang', 'The Lifecycle Of Software Objects', '978-1-59606-317-4'],
+    [true], ['zerpaderp', 'Bambasherp Airways'],
+    ['xxxx-xxxx-xxxx-xxxx', 'mm/dd', 'Zapp Brannigan', '01/02/3066'],
+    [49], [64, 45], [64, 72], ['>>>', 0x8000, 2, 11], [false, true], [64, 45],
+    ['mm/dd', 'xxx-xxx-xxx-xxx', 'Zapp Brannigan', '01/02/3066'],
+    ['potato', '6.7kg', '02/13/1947'], ['02/27/1948', 'scallop', '3.4kg'],
+    ['448g', 'peppercorn', '03/17/1948', true],
+    [26, 'Taft, William Howard', '03/04/1909'],
+    ['Roosevelt, Franklin D', '03/04/1933', 32], ['collected'],
+    [44, 88, 49, 68], [1, 49, 71], [984, 2016, 'fixed'],
+    [0, 0, 0, 'pristine', 'daily'],
+    [1], ['q', '2'], [13, '*', 4.7, 5.9], ['Wiggins', 'woofer', 4, 'papillon'],
+    ['Ted Chiang', 'The Lifecycle Of Software Objects', '978-1-59606-317-4'],
+    [true], ['zerpaderp', 'Bambasherp Airways'],
+    ['xxxx-xxxx-xxxx-xxxx', 'mm/dd', 'Zapp Brannigan', '01/02/3066'],
+    [49], [64, 45], [64, 72], ['>>>', 0x8000, 2, 11], [false, true], [64, 45],
+    ['mm/dd', 'xxx-xxx-xxx-xxx', 'Zapp Brannigan', '01/02/3066'],
+    ['potato', '6.7kg', '02/13/1947'], ['02/27/1948', 'scallop', '3.4kg'],
+    ['448g', 'peppercorn', '03/17/1948', true],
+    [26, 'Taft, William Howard', '03/04/1909'],
+    ['Roosevelt, Franklin D', '03/04/1933', 32], ['collected'],
+    [44, 88, 49, 68], [1, 49, 71], [984, 2016, 'fixed'],
+    [0, 0, 0, 'pristine', 'daily'],
+    [1], ['q', '2'], [13, '*', 4.7, 5.9], ['Wiggins', 'woofer', 4, 'papillon'],
+    ['Ted Chiang', 'The Lifecycle Of Software Objects', '978-1-59606-317-4'],
+    [true], ['zerpaderp', 'Bambasherp Airways'],
+    ['xxxx-xxxx-xxxx-xxxx', 'mm/dd', 'Zapp Brannigan', '01/02/3066'],
+    [49], [64, 45], [64, 72], ['>>>', 0x8000, 2, 11], [false, true], [64, 45],
+    ['mm/dd', 'xxx-xxx-xxx-xxx', 'Zapp Brannigan', '01/02/3066'],
+    ['potato', '6.7kg', '02/13/1947'], ['02/27/1948', 'scallop', '3.4kg'],
+    ['448g', 'peppercorn', '03/17/1948', true],
+    [26, 'Taft, William Howard', '03/04/1909'],
+    ['Roosevelt, Franklin D', '03/04/1933', 32], ['collected'],
+    [44, 88, 49, 68], [1, 49, 71], [984, 2016, 'fixed'],
+    [0, 0, 0, 'pristine', 'daily'],
+    [1], ['q', '2'], [13, '*', 4.7, 5.9], ['Wiggins', 'woofer', 4, 'papillon'],
+    ['Ted Chiang', 'The Lifecycle Of Software Objects', '978-1-59606-317-4'],
+    [true], ['zerpaderp', 'Bambasherp Airways'],
+    ['xxxx-xxxx-xxxx-xxxx', 'mm/dd', 'Zapp Brannigan', '01/02/3066'],
+    [49], [64, 45], [64, 72], ['>>>', 0x8000, 2, 11], [false, true], [64, 45],
+    ['mm/dd', 'xxx-xxx-xxx-xxx', 'Zapp Brannigan', '01/02/3066'],
+    ['potato', '6.7kg', '02/13/1947'], ['02/27/1948', 'scallop', '3.4kg'],
+    ['448g', 'peppercorn', '03/17/1948', true],
+    [26, 'Taft, William Howard', '03/04/1909'],
+    ['Roosevelt, Franklin D', '03/04/1933', 32], ['collected'],
+    [44, 88, 49, 68], [1, 49, 71], [984, 2016, 'fixed'],
+    [0, 0, 0, 'pristine', 'daily']
+  ];
+
+  if (!deepEquals(expected, result)) {
+    throw new Error("FAILURE");
+  }
+  return true;
+}