Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: runtime/bin/secure_socket.h

Issue 1746363002: Fixes error handling, leaks in secure sockets. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Added comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/secure_socket.cc » ('j') | runtime/bin/secure_socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/secure_socket.h
diff --git a/runtime/bin/secure_socket.h b/runtime/bin/secure_socket.h
index bd5eda301e50cf7826d20714aac466ab4b8aed92..754d2402e62a30b5d0cf5d91eb6fc526adb59fb1 100644
--- a/runtime/bin/secure_socket.h
+++ b/runtime/bin/secure_socket.h
@@ -62,7 +62,9 @@ class SSLFilter {
in_handshake_(false),
hostname_(NULL) { }
- void Init(Dart_Handle dart_this);
+ ~SSLFilter();
+
+ Dart_Handle Init(Dart_Handle dart_this);
void Connect(const char* hostname,
SSL_CTX* context,
bool is_server,
@@ -120,7 +122,7 @@ class SSLFilter {
static bool isBufferEncrypted(int i) {
return static_cast<BufferIndex>(i) >= kFirstEncrypted;
}
- void InitializeBuffers(Dart_Handle dart_this);
+ Dart_Handle InitializeBuffers(Dart_Handle dart_this);
void InitializePlatformData();
DISALLOW_COPY_AND_ASSIGN(SSLFilter);
« no previous file with comments | « no previous file | runtime/bin/secure_socket.cc » ('j') | runtime/bin/secure_socket.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698