Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3521)

Unified Diff: chrome/test/data/extensions/api_test/bookmarks/test.js

Issue 174633: Add browser tests for extensions tab API. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/bookmarks/test.js
===================================================================
--- chrome/test/data/extensions/api_test/bookmarks/test.js (revision 24947)
+++ chrome/test/data/extensions/api_test/bookmarks/test.js (working copy)
@@ -10,6 +10,8 @@
}
];
+var testCallback = chrome.test.testCallback;
+
function compareNode(left, right) {
//console.log(JSON.stringify(left));
//console.log(JSON.stringify(right));
@@ -52,7 +54,7 @@
chrome.test.runTests([
function getTree() {
- chrome.bookmarks.getTree(chrome.test.testFunction(function(results) {
+ chrome.bookmarks.getTree(testCallback(true, function(results) {
chrome.test.assertTrue(compareTrees(results, expected),
"getTree() result != expected");
expected = results;
@@ -60,14 +62,13 @@
},
function get() {
- chrome.bookmarks.get("1", chrome.test.testFunction(function(results) {
+ chrome.bookmarks.get("1", testCallback(true, function(results) {
chrome.test.assertTrue(compareNode(results[0], expected[0].children[0]));
}));
},
function getArray() {
- chrome.bookmarks.get(["1", "2"],
- chrome.test.testFunction(function(results) {
+ chrome.bookmarks.get(["1", "2"], testCallback(true, function(results) {
chrome.test.assertTrue(compareNode(results[0], expected[0].children[0]),
"get() result != expected");
chrome.test.assertTrue(compareNode(results[1], expected[0].children[1]),
@@ -76,8 +77,7 @@
},
function getChildren() {
- chrome.bookmarks.getChildren("0",
- chrome.test.testFunction(function(results) {
+ chrome.bookmarks.getChildren("0", testCallback(true, function(results) {
chrome.test.assertTrue(compareNode(results[0], expected[0].children[0]),
"getChildren() result != expected");
chrome.test.assertTrue(compareNode(results[1], expected[0].children[1]),
@@ -87,7 +87,7 @@
function create() {
var node = {parentId: "1", title:"google", url:"http://www.google.com/"};
- chrome.bookmarks.create(node, chrome.test.testFunction(function(results) {
+ chrome.bookmarks.create(node, testCallback(true, function(results) {
node.id = results.id; // since we couldn't know this going in
node.index = 0;
chrome.test.assertTrue(compareNode(node, results),
« no previous file with comments | « chrome/renderer/resources/extension_apitest.js ('k') | chrome/test/data/extensions/api_test/override1/test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698