src/objects.cc - Issue 1746323002: Ensure the @@species protector is updated for accessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1746323002: Ensure the @@species protector is updated for accessors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Apply Toon's suggestion Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 114e8d940dff3f1aa8f75b6a2c12d6cbf57a11e8..d669943db93f727b62d4304b17357cc9df53a36c 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -8970,6 +8970,8 @@ MaybeHandle<Object> JSObject::DefineAccessor(LookupIterator* it,

PropertyAttributes attributes) {

Isolate* isolate = it->isolate();

+ it->UpdateProtector();

if (it->state() == LookupIterator::ACCESS_CHECK) {

if (!it->HasAccess()) {

isolate->ReportFailedAccessCheck(it->GetHolder<JSObject>());

« no previous file with comments | « no previous file | test/mjsunit/harmony/array-species-constructor-accessor.js » ('j') | no next file with comments »