Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1746323002: Ensure the @@species protector is updated for accessors (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
adamk, Toon Verwaest
CC:
Camillo Bruni, v8-reviews_googlegroups.com, Toon Verwaest
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure the @@species protector is updated for accessors The initial species protector hooked into property declaration in an incomplete place, and missed definitions of accessors. This patch repairs them by calling out to update the protector from an additional location. R=adamk CC=verwaest,cbruni BUG=v8:4093 LOG=Y Committed: https://crrev.com/3f8af30ee7377e9013a3be93e6ca9e9ec51f926b Cr-Commit-Position: refs/heads/master@{#34599}

Patch Set 1 #

Patch Set 2 : Apply Toon's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/objects.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/array-species-constructor-accessor.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746323002/1
4 years, 9 months ago (2016-02-29 23:03:15 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 23:31:43 UTC) #4
Dan Ehrenberg
4 years, 9 months ago (2016-02-29 23:32:47 UTC) #5
adamk
I'll defer to Toon here, I don't know enough about the current state of lookups ...
4 years, 9 months ago (2016-03-01 02:24:28 UTC) #7
Dan Ehrenberg
On 2016/03/01 at 02:24:28, adamk wrote: > I'll defer to Toon here, I don't know ...
4 years, 9 months ago (2016-03-04 00:35:27 UTC) #8
Toon Verwaest
As discussed, please move the call into DefineAccessor. Otherwise lgtm
4 years, 9 months ago (2016-03-07 19:38:23 UTC) #9
Dan Ehrenberg
Done
4 years, 9 months ago (2016-03-08 19:27:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746323002/20001
4 years, 9 months ago (2016-03-08 19:27:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 19:54:28 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 19:55:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f8af30ee7377e9013a3be93e6ca9e9ec51f926b
Cr-Commit-Position: refs/heads/master@{#34599}

Powered by Google App Engine
This is Rietveld 408576698