Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1746293002: Adding Deprecation Message for <keygen> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2623
Patch Set: Undoing change. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 count(frame, feature); 742 count(frame, feature);
743 } 743 }
744 744
745 static const char* milestoneString(int milestone) 745 static const char* milestoneString(int milestone)
746 { 746 {
747 switch (milestone) { 747 switch (milestone) {
748 case 50: 748 case 50:
749 return "M50, around April 2016"; 749 return "M50, around April 2016";
750 case 53: 750 case 53:
751 return "M53, around September 2016"; 751 return "M53, around September 2016";
752 case 54:
753 return "M54, around October 2016";
752 } 754 }
753 755
754 ASSERT_NOT_REACHED(); 756 ASSERT_NOT_REACHED();
755 return nullptr; 757 return nullptr;
756 } 758 }
757 759
758 static String replacedBy(const char* feature, const char* replacement) 760 static String replacedBy(const char* feature, const char* replacement)
759 { 761 {
760 return String::format("%s is deprecated. Please use %s instead.", feature, r eplacement); 762 return String::format("%s is deprecated. Please use %s instead.", feature, r eplacement);
761 } 763 }
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
979 981
980 case RTCPeerConnectionCreateOfferLegacyNoFailureCallback: 982 case RTCPeerConnectionCreateOfferLegacyNoFailureCallback:
981 return "RTCPeerConnection.CreateOffer without a failure callback is depr ecated. The failure callback will be a required parameter in M50. See https://ww w.chromestatus.com/feature/5663288008376320 for more details"; 983 return "RTCPeerConnection.CreateOffer without a failure callback is depr ecated. The failure callback will be a required parameter in M50. See https://ww w.chromestatus.com/feature/5663288008376320 for more details";
982 984
983 case ObjectObserve: 985 case ObjectObserve:
984 return willBeRemoved("'Object.observe'", 50, "6147094632988672"); 986 return willBeRemoved("'Object.observe'", 50, "6147094632988672");
985 987
986 case NonCSSStyleSheetType: 988 case NonCSSStyleSheetType:
987 return String::format("Using stylesheet links with types other than 'tex t/css' is deprecated and will be removed in %s.", milestoneString(50)); 989 return String::format("Using stylesheet links with types other than 'tex t/css' is deprecated and will be removed in %s.", milestoneString(50));
988 990
991 case HTMLKeygenElement:
992 return willBeRemoved("The <keygen> element", 54, "5716060992962560");
993
989 // Features that aren't deprecated don't have a deprecation message. 994 // Features that aren't deprecated don't have a deprecation message.
990 default: 995 default:
991 return String(); 996 return String();
992 } 997 }
993 } 998 }
994 999
995 void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID feature) 1000 void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID feature)
996 { 1001 {
997 ASSERT(feature >= firstCSSProperty); 1002 ASSERT(feature >= firstCSSProperty);
998 ASSERT(feature <= lastUnresolvedCSSProperty); 1003 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
1026 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 1031 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
1027 { 1032 {
1028 // FIXME: We may want to handle stylesheets that have multiple owners 1033 // FIXME: We may want to handle stylesheets that have multiple owners
1029 // https://crbug.com/242125 1034 // https://crbug.com/242125
1030 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1035 if (sheetContents && sheetContents->hasSingleOwnerNode())
1031 return getFrom(sheetContents->singleOwnerDocument()); 1036 return getFrom(sheetContents->singleOwnerDocument());
1032 return 0; 1037 return 0;
1033 } 1038 }
1034 1039
1035 } // namespace blink 1040 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698