third_party/WebKit/Source/platform/audio/Panner.h - Issue 1746283002: Rename enums/functions that collide in chromium style in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/Panner.h

Issue 1746283002: Rename enums/functions that collide in chromium style in platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/animation/TimingFunction.cpp ('k') | third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp » ('j') | third_party/WebKit/Source/platform/fonts/FontDescription.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/audio/Panner.h

diff --git a/third_party/WebKit/Source/platform/audio/Panner.h b/third_party/WebKit/Source/platform/audio/Panner.h

index 84662f0d5c8b7a50f7bbad024f1a57924f1f871f..192ee6a5346dae075ae58b52f27f55f65f264d6e 100644

--- a/third_party/WebKit/Source/platform/audio/Panner.h

+++ b/third_party/WebKit/Source/platform/audio/Panner.h

@@ -57,8 +57,6 @@ public:

virtual ~Panner() { };

- PanningModel panningModel() const { return m_panningModel; }

Raymond Toy 2016/02/29 22:28:29 DBYC: Does panningModel() conflict? If not, then

danakj 2016/02/29 22:35:32 Yep. PanningModel PanningModel() is ambiguous.

virtual void pan(double azimuth, double elevation, const AudioBus* inputBus, AudioBus* outputBus, size_t framesToProcess) = 0;

virtual void reset() = 0;