src/gpu/SkGr.cpp - Issue 1746253002: Progress on gamma-correctness in the GPU backend. Fixed conversion of color and profile type to pix…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/SkGr.cpp

Issue 1746253002: Progress on gamma-correctness in the GPU backend. Fixed conversion of color and profile type to pix… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase and switch back to kN32 color type. Fixes DM crash on some configs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/SkGr.cpp

diff --git a/src/gpu/SkGr.cpp b/src/gpu/SkGr.cpp

index a3848c77e01de508f9c22a96e8c4b2d0f69d8454..4106d494b1f07d9f0cebc716d03dcefaef302daf 100644

--- a/src/gpu/SkGr.cpp

+++ b/src/gpu/SkGr.cpp

@@ -370,12 +370,13 @@ GrPixelConfig SkImageInfo2GrPixelConfig(SkColorType ct, SkAlphaType, SkColorProf

case kARGB_4444_SkColorType:

return kRGBA_4444_GrPixelConfig;

case kRGBA_8888_SkColorType:

- //if (kSRGB_SkColorProfileType == pt) {

- // return kSRGBA_8888_GrPixelConfig;

- //}

- return kRGBA_8888_GrPixelConfig;

+ return (kSRGB_SkColorProfileType == pt)

+ ? kSRGBA_8888_GrPixelConfig

+ : kRGBA_8888_GrPixelConfig;

case kBGRA_8888_SkColorType:

- return kBGRA_8888_GrPixelConfig;

+ return (kSRGB_SkColorProfileType == pt)

+ ? kSRGBA_8888_GrPixelConfig // Does not preserve byte order!

+ : kBGRA_8888_GrPixelConfig;

case kIndex_8_SkColorType:

return kIndex_8_GrPixelConfig;

case kGray_8_SkColorType:

« no previous file with comments | « dm/DMSrcSink.cpp ('k') | tests/TestConfigParsing.cpp » ('j') | no next file with comments »