Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tools/flags/SkCommonFlagsConfig.h

Issue 1746253002: Progress on gamma-correctness in the GPU backend. Fixed conversion of color and profile type to pix… (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase and switch back to kN32 color type. Fixes DM crash on some configs. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/TestConfigParsing.cpp ('k') | tools/flags/SkCommonFlagsConfig.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SK_COMMON_FLAGS_CONFIG_H 8 #ifndef SK_COMMON_FLAGS_CONFIG_H
9 #define SK_COMMON_FLAGS_CONFIG_H 9 #define SK_COMMON_FLAGS_CONFIG_H
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 #if SK_SUPPORT_GPU 46 #if SK_SUPPORT_GPU
47 // SkCommandLineConfigGpu is a SkCommandLineConfig that extracts information out of the backend 47 // SkCommandLineConfigGpu is a SkCommandLineConfig that extracts information out of the backend
48 // part of the tag. It is constructed tags that have: 48 // part of the tag. It is constructed tags that have:
49 // * backends of form "gpu(option=value,option2=value,...)" 49 // * backends of form "gpu(option=value,option2=value,...)"
50 // * backends that represent a shorthand of above (such as "msaa16" representing "gpu(samples=16)") 50 // * backends that represent a shorthand of above (such as "msaa16" representing "gpu(samples=16)")
51 class SkCommandLineConfigGpu : public SkCommandLineConfig { 51 class SkCommandLineConfigGpu : public SkCommandLineConfig {
52 public: 52 public:
53 typedef GrContextFactory::GLContextType ContextType; 53 typedef GrContextFactory::GLContextType ContextType;
54 SkCommandLineConfigGpu(const SkString& tag, const SkTArray<SkString>& viaPar ts, 54 SkCommandLineConfigGpu(const SkString& tag, const SkTArray<SkString>& viaPar ts,
55 ContextType contextType, bool useNVPR, bool useDIText , int samples); 55 ContextType contextType, bool useNVPR, bool useDIText , int samples,
56 SkColorType colorType, SkColorProfileType profileType );
56 const SkCommandLineConfigGpu* asConfigGpu() const override { return this; } 57 const SkCommandLineConfigGpu* asConfigGpu() const override { return this; }
57 ContextType getContextType() const { return fContextType; } 58 ContextType getContextType() const { return fContextType; }
58 bool getUseNVPR() const { return fUseNVPR; } 59 bool getUseNVPR() const { return fUseNVPR; }
59 bool getUseDIText() const { return fUseDIText; } 60 bool getUseDIText() const { return fUseDIText; }
60 int getSamples() const { return fSamples; } 61 int getSamples() const { return fSamples; }
62 SkColorType getColorType() const { return fColorType; }
63 SkColorProfileType getProfileType() const { return fProfileType; }
61 64
62 private: 65 private:
63 ContextType fContextType; 66 ContextType fContextType;
64 bool fUseNVPR; 67 bool fUseNVPR;
65 bool fUseDIText; 68 bool fUseDIText;
66 int fSamples; 69 int fSamples;
70 SkColorType fColorType;
71 SkColorProfileType fProfileType;
67 }; 72 };
68 #endif 73 #endif
69 74
70 typedef SkTArray<SkAutoTDelete<SkCommandLineConfig>, true> SkCommandLineConfigAr ray; 75 typedef SkTArray<SkAutoTDelete<SkCommandLineConfig>, true> SkCommandLineConfigAr ray;
71 void ParseConfigs(const SkCommandLineFlags::StringArray& configList, 76 void ParseConfigs(const SkCommandLineFlags::StringArray& configList,
72 SkCommandLineConfigArray* outResult); 77 SkCommandLineConfigArray* outResult);
73 78
74 #endif 79 #endif
OLDNEW
« no previous file with comments | « tests/TestConfigParsing.cpp ('k') | tools/flags/SkCommonFlagsConfig.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698