Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1746243002: Speculative fix for windows broken at d5e7b355b8c4. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Speculative fix for windows broken at d5e7b355b8c4. I'm guessing that |small| is #defined somewhere. TBR=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bf85bd7234e5fc0120315007dec085d741dcfb7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/include/fxcrt/fx_coordinates.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, build broken.
4 years, 9 months ago (2016-02-29 19:52:22 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as bf85bd7234e5fc0120315007dec085d741dcfb7a (tree was closed).
4 years, 9 months ago (2016-02-29 19:52:44 UTC) #3
dsinclair
4 years, 9 months ago (2016-02-29 19:54:12 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698