Rename some index fields and use single 'UnitIndex.unit' field.

Rename some index fields and use single 'UnitIndex.unit' field.

The added prefix 'usedElement' groups fields in UnitIndex.
In a next CL I will add also 'usedName' field set for indexing used
names, resolved and unresolved.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/db2fd1ef1e1e82cd77669324b1b9f6f5335c5911

[Paul Berry, 2016-02-29 18:39:01]

Assuming you agree with my suggestion below, lgtm.

https://codereview.chromium.org/1746113002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1746113002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:596: unit:
pkg._getUnitId(unitElement),
I don't think this is a bug but I'm nervous about it. 
PackageIndexAssembler.assemble() stores _unitLibraryUris and _unitUnitUris in
the PackageIndexBuilder prior to calling _UnitIndexAssembler.assemble().  Which
means that we might wind up calling pkg._getUnitId() (which could modify those
lists) after they've been stored in PackageIndexBuilder.

Fortunately, the PackageIndexBuilder constructor doesn't make copies of
_unitLibraryUris and _unitUnitUris, so we are ok.  But that's an implementation
detail of PackageIndexBuilder that we shouldn't rely on--if we ever changed it
so that it *did* make copies, this code would break.

I would prefer to have an implementation that doesn't rely on the fact that
PackageIndexBuilder doesn't make copies.

Possible solution: move the call to pkg._getUnitId() into the
_UnitIndexAssembler constructor, and store its return value as a field in
_UnitIndexAssembler rather than storing [unitElement].

[scheglov, 2016-02-29 18:48:28]

https://codereview.chromium.org/1746113002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1746113002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:596: unit:
pkg._getUnitId(unitElement),
On 2016/02/29 18:39:01, Paul Berry wrote:
> I don't think this is a bug but I'm nervous about it. 
> PackageIndexAssembler.assemble() stores _unitLibraryUris and _unitUnitUris in
> the PackageIndexBuilder prior to calling _UnitIndexAssembler.assemble(). 
Which
> means that we might wind up calling pkg._getUnitId() (which could modify those
> lists) after they've been stored in PackageIndexBuilder.
> 
> Fortunately, the PackageIndexBuilder constructor doesn't make copies of
> _unitLibraryUris and _unitUnitUris, so we are ok.  But that's an
implementation
> detail of PackageIndexBuilder that we shouldn't rely on--if we ever changed it
> so that it *did* make copies, this code would break.
> 
> I would prefer to have an implementation that doesn't rely on the fact that
> PackageIndexBuilder doesn't make copies.
> 
> Possible solution: move the call to pkg._getUnitId() into the
> _UnitIndexAssembler constructor, and store its return value as a field in
> _UnitIndexAssembler rather than storing [unitElement].

Thank you.
I changed it to pass unitId into the UnitIndex constructor.

[scheglov, 2016-02-29 18:50:24]

Description was changed from

==========
Rename some index fields and use single 'UnitIndex.unit' field.

The added prefix 'usedElement' groups fields in UnitIndex.
In a next CL I will add also 'usedName' field set for indexing used
names, resolved and unresolved.

R=paulberry@google.com
BUG=
==========

to

==========
Rename some index fields and use single 'UnitIndex.unit' field.

The added prefix 'usedElement' groups fields in UnitIndex.
In a next CL I will add also 'usedName' field set for indexing used
names, resolved and unresolved.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/db2fd1ef1e1e82cd77669324b1b9f6f5335c5911
==========

[scheglov, 2016-02-29 18:50:26]

Committed patchset #1 (id:1) manually as
db2fd1ef1e1e82cd77669324b1b9f6f5335c5911 (presubmit successful).