|
|
DescriptionFix overlooked bilerp fallback.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1746093002
Committed: https://skia.googlesource.com/skia/+/755539f0b1f3331359d1ea2b65b6bb93387b7821
Patch Set 1 #Patch Set 2 : Simplify fallback. #
Total comments: 2
Messages
Total messages: 23 (11 generated)
Description was changed from ========== Fix overlooked bilerp fallback. BUG=skia: ========== to ========== Fix overlooked bilerp fallback. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Fix overlooked bilerp fallback. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Fix overlooked bilerp fallback. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
herb@google.com changed reviewers: + mtklein@google.com, reed@google.com
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746093002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by herb@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746093002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-03-01 00:39 UTC
Simplify fallback.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746093002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mtklein@chromium.org changed reviewers: + mtklein@chromium.org
lgtm https://codereview.chromium.org/1746093002/diff/20001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746093002/diff/20001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:436: Xs = Xs + dXs; Xs = Xs + dx
The CQ bit was checked by herb@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746093002/20001
https://codereview.chromium.org/1746093002/diff/20001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746093002/diff/20001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:436: Xs = Xs + dXs; On 2016/02/29 20:19:45, mtklein_C wrote: > Xs = Xs + dx Acknowledged.
Message was sent while issue was closed.
Description was changed from ========== Fix overlooked bilerp fallback. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Fix overlooked bilerp fallback. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/755539f0b1f3331359d1ea2b65b6bb93387b7821 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/755539f0b1f3331359d1ea2b65b6bb93387b7821 |