Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1746093002: Fix overlooked bilerp fallback. (Closed)

Created:
4 years, 9 months ago by herb_g
Modified:
4 years, 9 months ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Simplify fallback. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/core/SkLinearBitmapPipeline.cpp View 1 1 chunk +13 lines, -1 line 2 comments Download

Messages

Total messages: 23 (11 generated)
herb_g
4 years, 9 months ago (2016-02-29 17:37:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746093002/1
4 years, 9 months ago (2016-02-29 17:38:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 17:51:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746093002/1
4 years, 9 months ago (2016-02-29 18:39:15 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-02-29 18:39:16 UTC) #11
herb_g
Simplify fallback.
4 years, 9 months ago (2016-02-29 20:04:22 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746093002/20001
4 years, 9 months ago (2016-02-29 20:05:21 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 20:18:52 UTC) #16
mtklein_C
lgtm https://codereview.chromium.org/1746093002/diff/20001/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746093002/diff/20001/src/core/SkLinearBitmapPipeline.cpp#newcode436 src/core/SkLinearBitmapPipeline.cpp:436: Xs = Xs + dXs; Xs = Xs ...
4 years, 9 months ago (2016-02-29 20:19:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746093002/20001
4 years, 9 months ago (2016-02-29 20:57:39 UTC) #20
herb_g
https://codereview.chromium.org/1746093002/diff/20001/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746093002/diff/20001/src/core/SkLinearBitmapPipeline.cpp#newcode436 src/core/SkLinearBitmapPipeline.cpp:436: Xs = Xs + dXs; On 2016/02/29 20:19:45, mtklein_C ...
4 years, 9 months ago (2016-02-29 20:57:40 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 20:58:38 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/755539f0b1f3331359d1ea2b65b6bb93387b7821

Powered by Google App Engine
This is Rietveld 408576698