Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1746083002: Timeout expectation for h/t/s/mc/active-subresource-in-http-iframe-not-blocked.https.html. (Closed)

Created:
4 years, 9 months ago by Łukasz Anforowicz
Modified:
4 years, 9 months ago
Reviewers:
estark
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeout expectation for h/t/s/mc/active-subresource-in-http-iframe-not-blocked.https.html. This is a new test introduced in https://codereview.chromium.org/1731103007. BUG=590773 TBR=estark@chromium.org Committed: https://crrev.com/407b7d53c40b10d3940b44282352e9e49b0cec6b Cr-Commit-Position: refs/heads/master@{#378320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Łukasz Anforowicz
Emily, could you please take a look?
4 years, 9 months ago (2016-02-29 17:28:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746083002/1
4 years, 9 months ago (2016-02-29 21:13:11 UTC) #5
estark
lgtm (I'm trying to figure out why is timing out right now)
4 years, 9 months ago (2016-02-29 21:15:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 23:56:21 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/407b7d53c40b10d3940b44282352e9e49b0cec6b Cr-Commit-Position: refs/heads/master@{#378320}
4 years, 9 months ago (2016-02-29 23:57:36 UTC) #9
estark
I think this should actually go in the "testRunner.setAllowDisplayOfInsecureContent is not replicated to OOPIFs" section?
4 years, 9 months ago (2016-02-29 23:58:31 UTC) #10
Łukasz Anforowicz
4 years, 9 months ago (2016-03-01 00:17:37 UTC) #11
Message was sent while issue was closed.
On 2016/02/29 23:58:31, estark wrote:
> I think this should actually go in the
> "testRunner.setAllowDisplayOfInsecureContent is not replicated to OOPIFs"
> section?

Oh, ok - let me fix this in crrev.com/1750073002?

Thanks for digging into the timeout and my apologies for landing the test
expectation in a not-quite-the-right-shape (otoh, hopefully this will make the
bot green again :-).

Powered by Google App Engine
This is Rietveld 408576698