Remove foxitlib.h and foxitxfa.h and IWYU.

Remove foxitlib.h and foxitxfa.h and IWYU.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/b36430115717af4ecfa573476714cecc73f3d1c3

[dsinclair, 2016-02-29 18:26:46]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-02-29 18:26:47]

PTAL.

[Tom Sepez, 2016-02-29 19:22:31]

LGTM with comments.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fdp/src/xml/fde_xml...
File xfa/src/fdp/src/xml/fde_xml_imp.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fdp/src/xml/fde_xml...
xfa/src/fdp/src/xml/fde_xml_imp.cpp:16: static FX_WCHAR
g_XMLValidCharRange[FDE_XMLVALIDCHARRANGENUM][2] = {
nit: const while you're at it.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fee/src/fee/fde_txt...
File xfa/src/fee/src/fee/fde_txtedtparag.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fee/src/fee/fde_txt...
xfa/src/fee/src/fee/fde_txtedtparag.h:16: CFDE_TxtEdtParag(CFDE_TxtEdtEngine*
pEngine);
nit: explicit while you're at it.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fee/src/fx_wordbrea...
File xfa/src/fee/src/fx_wordbreak/fx_wordbreakdata.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fee/src/fx_wordbrea...
xfa/src/fee/src/fx_wordbreak/fx_wordbreakdata.cpp:9: extern const FX_WORD
gs_FX_WordBreak_Table[16] = {
nit: extern keyword not needed, several places in this file.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fwl/src/core/fwl_sd...
File xfa/src/fwl/src/core/fwl_sdadapterimp.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fwl/src/core/fwl_sd...
xfa/src/fwl/src/core/fwl_sdadapterimp.cpp:10: #include
"xfa/include/fwl/adapter/fwl_sdadapterimp.h"
This one should come first.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_locale.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_locale.cpp:20: static const FX_WCHAR* g_FX_Percent =
L"z,zzz,zzz,zzz,zzz,zzz%";
maybe static const FW_WCHAR g_FX_Percent[] = L"..."; while you're at it.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_localemgr.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_localemgr.cpp:14: #include
"xfa/src/fxfa/src/common/xfa_localemgr.h"
this one goes first.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_localevalue.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_localevalue.cpp:8: #include
"xfa/src/fxfa/src/common/xfa_docdata.h"
nit: blank line here.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_script_eventpseudomodel.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_script_eventpseudomodel.h:32:
CScript_EventPseudoModel(CXFA_Document* pDocument);
nit: explicit while you're at it.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_script_imp.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_script_imp.h:22: CXFA_ScriptContext(CXFA_Document*
pDocument);
nit: explicit

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_script_layoutpseudomodel.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_script_layoutpseudomodel.h:22:
CScript_LayoutPseudoModel(CXFA_Document* pDocument);
explicit

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_script_logpseudomodel.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_script_logpseudomodel.h:14:
CScript_LogPseudoModel(CXFA_Document* pDocument);
explicit

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxgraphics/src/pre.h
File xfa/src/fxgraphics/src/pre.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxgraphics/src/pre....
xfa/src/fxgraphics/src/pre.h:14: enum { FX_COLOR_None = 0, FX_COLOR_Solid,
FX_COLOR_Pattern, FX_COLOR_Shading };
strange formatting here. Also anonymous enum at top level?  Probably some int
/enum cleanup to be had in another CL.

[dsinclair, 2016-02-29 19:52:04]

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fdp/src/xml/fde_xml...
File xfa/src/fdp/src/xml/fde_xml_imp.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fdp/src/xml/fde_xml...
xfa/src/fdp/src/xml/fde_xml_imp.cpp:16: static FX_WCHAR
g_XMLValidCharRange[FDE_XMLVALIDCHARRANGENUM][2] = {
On 2016/02/29 19:22:30, Tom Sepez wrote:
> nit: const while you're at it.

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fee/src/fee/fde_txt...
File xfa/src/fee/src/fee/fde_txtedtparag.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fee/src/fee/fde_txt...
xfa/src/fee/src/fee/fde_txtedtparag.h:16: CFDE_TxtEdtParag(CFDE_TxtEdtEngine*
pEngine);
On 2016/02/29 19:22:30, Tom Sepez wrote:
> nit: explicit while you're at it.

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fee/src/fx_wordbrea...
File xfa/src/fee/src/fx_wordbreak/fx_wordbreakdata.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fee/src/fx_wordbrea...
xfa/src/fee/src/fx_wordbreak/fx_wordbreakdata.cpp:9: extern const FX_WORD
gs_FX_WordBreak_Table[16] = {
On 2016/02/29 19:22:30, Tom Sepez wrote:
> nit: extern keyword not needed, several places in this file.

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fwl/src/core/fwl_sd...
File xfa/src/fwl/src/core/fwl_sdadapterimp.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fwl/src/core/fwl_sd...
xfa/src/fwl/src/core/fwl_sdadapterimp.cpp:10: #include
"xfa/include/fwl/adapter/fwl_sdadapterimp.h"
On 2016/02/29 19:22:30, Tom Sepez wrote:
> This one should come first.

Wasn't sure about that one because the paths differ:

xfa/include/fwl/adapter/fwl_sadapterimp.h
xfa/src/fwl/src/core/fwl_sdadapterimp.cpp

The adapter vs core was what I wasn't sure about.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_locale.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_locale.cpp:20: static const FX_WCHAR* g_FX_Percent =
L"z,zzz,zzz,zzz,zzz,zzz%";
On 2016/02/29 19:22:30, Tom Sepez wrote:
> maybe static const FW_WCHAR g_FX_Percent[] = L"..."; while you're at it.

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_localemgr.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_localemgr.cpp:14: #include
"xfa/src/fxfa/src/common/xfa_localemgr.h"
On 2016/02/29 19:22:30, Tom Sepez wrote:
> this one goes first.

Done. Had skipped it due to the common vs parser difference.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_localevalue.cpp (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_localevalue.cpp:8: #include
"xfa/src/fxfa/src/common/xfa_docdata.h"
On 2016/02/29 19:22:30, Tom Sepez wrote:
> nit: blank line here.

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_script_eventpseudomodel.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_script_eventpseudomodel.h:32:
CScript_EventPseudoModel(CXFA_Document* pDocument);
On 2016/02/29 19:22:30, Tom Sepez wrote:
> nit: explicit while you're at it.

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_script_imp.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_script_imp.h:22: CXFA_ScriptContext(CXFA_Document*
pDocument);
On 2016/02/29 19:22:30, Tom Sepez wrote:
> nit: explicit

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_script_layoutpseudomodel.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_script_layoutpseudomodel.h:22:
CScript_LayoutPseudoModel(CXFA_Document* pDocument);
On 2016/02/29 19:22:30, Tom Sepez wrote:
> explicit

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
File xfa/src/fxfa/src/parser/xfa_script_logpseudomodel.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxfa/src/parser/xfa...
xfa/src/fxfa/src/parser/xfa_script_logpseudomodel.h:14:
CScript_LogPseudoModel(CXFA_Document* pDocument);
On 2016/02/29 19:22:30, Tom Sepez wrote:
> explicit

Done.

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxgraphics/src/pre.h
File xfa/src/fxgraphics/src/pre.h (right):

https://codereview.chromium.org/1746053003/diff/1/xfa/src/fxgraphics/src/pre....
xfa/src/fxgraphics/src/pre.h:14: enum { FX_COLOR_None = 0, FX_COLOR_Solid,
FX_COLOR_Pattern, FX_COLOR_Shading };
On 2016/02/29 19:22:30, Tom Sepez wrote:
> strange formatting here. Also anonymous enum at top level?  Probably some int
> /enum cleanup to be had in another CL.

Formatting is how git cl format seems to want it.

Filed https://bugs.chromium.org/p/pdfium/issues/detail?id=418 for the cleanup.

[dsinclair, 2016-02-29 20:03:21]

Description was changed from

==========
Remove foxitlib.h and foxitxfa.h and IWYU.
==========

to

==========
Remove foxitlib.h and foxitxfa.h and IWYU.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/b36430115717af4ecfa573476714cecc73f3...
==========

[dsinclair, 2016-02-29 20:03:23]

Committed patchset #3 (id:40001) manually as
b36430115717af4ecfa573476714cecc73f3d1c3 (presubmit successful).