Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 1746053002: [turbofan] Ensure that JS -> WASM calls align the csp on arm64 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/arm64/code-generator-arm64.cc
diff --git a/src/compiler/arm64/code-generator-arm64.cc b/src/compiler/arm64/code-generator-arm64.cc
index e45c677619393662a606fe0ff31b5da7a75a793d..5eb57c129ea91172fda28d4ff3a4ce94025d1cb0 100644
--- a/src/compiler/arm64/code-generator-arm64.cc
+++ b/src/compiler/arm64/code-generator-arm64.cc
@@ -933,8 +933,12 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
case kArm64ClaimCSP: {
int count = i.InputInt32(0);
Register prev = __ StackPointer();
- __ SetStackPointer(csp);
- __ Claim(count);
+ if (prev.Is(jssp)) {
+ __ AlignAndSetCSPForFrame();
+ }
+ if (count > 0) {
+ __ Claim(count);
+ }
__ SetStackPointer(prev);
frame_access_state()->IncreaseSPDelta(count);
break;
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698