Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 1746053002: [turbofan] Ensure that JS -> WASM calls align the csp on arm64 (Closed)

Created:
4 years, 9 months ago by danno
Modified:
4 years, 9 months ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ensure that JS -> WASM calls align the csp on arm64 This is done by ensuring that the Arm64ClaimCSP instruction calls AlignAndSetCSPForFrame when it's generated when the StackPointer() is set to jssp. LOG=N Committed: https://crrev.com/f1d49ca3f223ce797fc84345dc4d138b1e264ea5 Cr-Commit-Position: refs/heads/master@{#34365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
danno
PTAL. I discovered this when porting my more compact stack frame format CL to arm64.
4 years, 9 months ago (2016-02-29 16:12:12 UTC) #3
ahaas
lgtm
4 years, 9 months ago (2016-02-29 16:16:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746053002/1
4 years, 9 months ago (2016-02-29 16:20:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11649)
4 years, 9 months ago (2016-02-29 16:24:30 UTC) #8
titzer
On 2016/02/29 16:24:30, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-02-29 16:40:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746053002/1
4 years, 9 months ago (2016-02-29 16:49:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 16:51:16 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 16:52:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1d49ca3f223ce797fc84345dc4d138b1e264ea5
Cr-Commit-Position: refs/heads/master@{#34365}

Powered by Google App Engine
This is Rietveld 408576698