Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1746023003: Fix compile failure in disk cache backend tests. (Closed)

Created:
4 years, 9 months ago by gavinp
Modified:
4 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Fix compile failure in disk cache backend tests. A refactor in m50 made noticing this problem tricky. Now fixed. TBR=mmenke@chromium.org BUG=590795 Committed: https://chromium.googlesource.com/chromium/src/+/f0339264d6afa4960fdc1da9f8e4d3e01b1302a5

Patch Set 1 #

Patch Set 2 : narrowed (by rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/disk_cache/backend_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
gavinp
Committed patchset #2 (id:20001) manually as f0339264d6afa4960fdc1da9f8e4d3e01b1302a5 (presubmit successful).
4 years, 9 months ago (2016-02-29 18:38:59 UTC) #2
mmenke
4 years, 9 months ago (2016-02-29 18:41:38 UTC) #3
Message was sent while issue was closed. 
On 2016/02/29 18:38:59, gavinp wrote:
> Committed patchset #2 (id:20001) manually as
> f0339264d6afa4960fdc1da9f8e4d3e01b1302a5 (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698