More cleanup of net_log.h

More cleanup to address TODOs in net_log.h.

  * Removes 9 methods: AddEventWithParameters, BeginEventWithParameters, EndEventWithParameters, BeginEventWithString, BeginEventWithInteger, AddEventWithString, AddEventWithInteger, EndEventWithParameters, EndEventWithInteger. This was becoming ridiculous, instead made the EventParameters* a required parameter.
  * Moves CapturingBoundNetLog / CapturingNetLog to its own file.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45843

[willchan no longer on Chromium, 2010-04-28 17:15:36]

LGTM

http://codereview.chromium.org/1746012/diff/1/25
File net/base/capturing_net_log.h (left):

http://codereview.chromium.org/1746012/diff/1/25#oldcode11
net/base/capturing_net_log.h:11: #include "base/basictypes.h"
You need this include for DISALLOW_COPY_AND_ASSIGN.

http://codereview.chromium.org/1746012/diff/1/25
File net/base/capturing_net_log.h (right):

http://codereview.chromium.org/1746012/diff/1/25#newcode44
net/base/capturing_net_log.h:44: explicit CapturingNetLog(size_t
max_num_entries)
Nit: In general I prefer having these constructors in the .cc.  Minimizes the
inlining of the constructor which is non-trivially sized (the EntryList
constructor will be large).

http://codereview.chromium.org/1746012/diff/1/30
File net/base/net_log.cc (right):

http://codereview.chromium.org/1746012/diff/1/30#newcode6
net/base/net_log.cc:6: #include "base/logging.h"
I don't think you need this include?  Dunno where logging.h is used here.  Same
with string_util.h.

http://codereview.chromium.org/1746012/diff/1/27
File net/base/net_log.h (right):

http://codereview.chromium.org/1746012/diff/1/27#newcode162
net/base/net_log.h:162: // currently bound source, current time, and a fixed
CapturePhase.
CapturePhase?  What's that?

[eroman, 2010-04-28 17:43:03]

Thanks for the review

http://codereview.chromium.org/1746012/diff/1/25
File net/base/capturing_net_log.h (left):

http://codereview.chromium.org/1746012/diff/1/25#oldcode11
net/base/capturing_net_log.h:11: #include "base/basictypes.h"
On 2010/04/28 17:15:37, willchan wrote:
> You need this include for DISALLOW_COPY_AND_ASSIGN.

Done.

http://codereview.chromium.org/1746012/diff/1/25
File net/base/capturing_net_log.h (right):

http://codereview.chromium.org/1746012/diff/1/25#newcode44
net/base/capturing_net_log.h:44: explicit CapturingNetLog(size_t
max_num_entries)
On 2010/04/28 17:15:37, willchan wrote:
> Nit: In general I prefer having these constructors in the .cc.  Minimizes the
> inlining of the constructor which is non-trivially sized (the EntryList
> constructor will be large).

Done.

http://codereview.chromium.org/1746012/diff/1/30
File net/base/net_log.cc (right):

http://codereview.chromium.org/1746012/diff/1/30#newcode6
net/base/net_log.cc:6: #include "base/logging.h"
On 2010/04/28 17:15:37, willchan wrote:
> I don't think you need this include?  Dunno where logging.h is used here. 
Same
> with string_util.h.

Done.

http://codereview.chromium.org/1746012/diff/1/27
File net/base/net_log.h (right):

http://codereview.chromium.org/1746012/diff/1/27#newcode162
net/base/net_log.h:162: // currently bound source, current time, and a fixed
CapturePhase.
On 2010/04/28 17:15:37, willchan wrote:
> CapturePhase?  What's that?

Done.