Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h

Issue 1745933002: Replace ActiveDOMObjects in modules/indexeddb/ with ContextLifecycleObservers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h b/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
index d733d2232ddac74a82cd854629e980cb6e363dc0..9acf0fa65ed29d8324db19a79612fd390cd1ebe9 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
@@ -27,7 +27,7 @@
#define IDBTransaction_h
#include "bindings/core/v8/ScriptState.h"
-#include "core/dom/ActiveDOMObject.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/events/EventListener.h"
#include "modules/EventModules.h"
#include "modules/EventTargetModules.h"
@@ -50,7 +50,7 @@ struct IDBObjectStoreMetadata;
class MODULES_EXPORT IDBTransaction final
: public RefCountedGarbageCollectedEventTargetWithInlineData<IDBTransaction>
- , public ActiveDOMObject {
+ , public ContextLifecycleObserver {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(IDBTransaction);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(IDBTransaction);
DEFINE_WRAPPERTYPEINFO();
@@ -98,9 +98,8 @@ public:
const AtomicString& interfaceName() const override;
ExecutionContext* executionContext() const override;
- // ActiveDOMObject
bool hasPendingActivity() const override;
- void stop() override;
+ void contextDestroyed() override;
protected:
// EventTarget
@@ -125,7 +124,6 @@ private:
const WebIDBTransactionMode m_mode;
State m_state = Active;
bool m_hasPendingActivity = true;
- bool m_contextStopped = false;
Member<DOMException> m_error;
HeapListHashSet<Member<IDBRequest>> m_requestList;

Powered by Google App Engine
This is Rietveld 408576698