Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h

Issue 1745933002: Replace ActiveDOMObjects in modules/indexeddb/ with ContextLifecycleObservers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
index 68ea08d6af36dc63534d5be53c7c0f9969f19e62..7e051a00e9b25c289cf656d96d84916952dff08c 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
@@ -28,7 +28,7 @@
#include "bindings/core/v8/ScriptState.h"
#include "bindings/modules/v8/UnionTypesModules.h"
-#include "core/dom/ActiveDOMObject.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/dom/DOMStringList.h"
#include "modules/EventModules.h"
#include "modules/EventTargetModules.h"
@@ -55,7 +55,7 @@ class ExecutionContext;
class MODULES_EXPORT IDBDatabase final
: public RefCountedGarbageCollectedEventTargetWithInlineData<IDBDatabase>
- , public ActiveDOMObject {
+ , public ContextLifecycleObserver {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(IDBDatabase);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(IDBDatabase);
DEFINE_WRAPPERTYPEINFO();
@@ -90,9 +90,8 @@ public:
void onAbort(int64_t, DOMException*);
void onComplete(int64_t);
- // ActiveDOMObject
bool hasPendingActivity() const override;
- void stop() override;
+ void contextDestroyed() override;
// EventTarget
const AtomicString& interfaceName() const override;
@@ -148,7 +147,6 @@ private:
HeapHashMap<int64_t, Member<IDBTransaction>> m_transactions;
bool m_closePending = false;
- bool m_contextStopped = false;
// Keep track of the versionchange events waiting to be fired on this
// database so that we can cancel them if the database closes.

Powered by Google App Engine
This is Rietveld 408576698