Remove use of deprecated methods to cricket::VideoCapturer in WebrtcVideoCapturerAdapter

Remove use of deprecated methods to cricket::VideoCapturer in WebrtcVideoCapturerAdapter

VideoCapturer::Pause is never used in the webrtc code base.
SignalgVideoFrame should also be removed and replaced with normal method call to VideoCapturer::OnFrame.

BUG=webrtc:5426
Committed: https://crrev.com/1f29be6be1b2671cc73cd8f83045b7e4a208216b
Cr-Commit-Position: refs/heads/master@{#383040}

[perkj_chrome, 2016-03-23 14:28:26]

Description was changed from

==========
Remove use of deprecated methods to cricket::VideoCapturer in
WebrtcVideoCapturerAdapter

BUG=
==========

to

==========
Remove use of deprecated methods to cricket::VideoCapturer in
WebrtcVideoCapturerAdapter

VideoCapturer::Pause is never used in the webrtc code base.
SignalgVideoFrame should also be removed and replaced with normal method call to
VideoCapturer::OnFrame.

BUG=webrtc:5426
==========

[perkj_chrome, 2016-03-23 14:45:05]

perkj@chromium.org changed reviewers:
+ sergeyu@chromium.org

[perkj_chrome, 2016-03-23 14:45:05]

Please?

[Sergey Ulanov, 2016-03-23 18:08:03]

No

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
File remoting/protocol/webrtc_video_capturer_adapter.cc (right):

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
remoting/protocol/webrtc_video_capturer_adapter.cc:74: // Similar to the base
class implementation with some important differences:
remove this comment please.

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
remoting/protocol/webrtc_video_capturer_adapter.cc:83: if (capture_state() ==
cricket::CS_PAUSED)
do we still have capture_state() in CapturerAdapter()? If yes, is PAUSED state
not deprecated? Should we have paused_ flag in this class?

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
File remoting/protocol/webrtc_video_capturer_adapter.h (right):

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
remoting/protocol/webrtc_video_capturer_adapter.h:60: bool PauseCapturer(bool
pause);
Since this is not part of the VideoCapturer interface anymore it needs to be
moved, e.g. after SetSizeCallback()

[Sergey Ulanov, 2016-03-23 18:16:10]

On 2016/03/23 18:08:03, Sergey Ulanov wrote:
> No

Sorry, didn't mean to write this "No", not sure where it came from. Thanks for
the cleanup!

[perkj_chrome, 2016-03-23 20:03:04]

Patchset #3 (id:40001) has been deleted

[perkj_chrome, 2016-03-23 20:11:45]

Fingers slip so easily :-)

Did you btw see my question for you in
https://codereview.chromium.org/1821153003/ if you capture into the whole size
of a frame every time or just a part of it? 

PTAL

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
File remoting/protocol/webrtc_video_capturer_adapter.cc (right):

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
remoting/protocol/webrtc_video_capturer_adapter.cc:74: // Similar to the base
class implementation with some important differences:
On 2016/03/23 18:08:03, Sergey Ulanov wrote:
> remove this comment please.

Done.

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
remoting/protocol/webrtc_video_capturer_adapter.cc:83: if (capture_state() ==
cricket::CS_PAUSED)
On 2016/03/23 18:08:03, Sergey Ulanov wrote:
> do we still have capture_state() in CapturerAdapter()? If yes, is PAUSED state
> not deprecated? Should we have paused_ flag in this class?

I should remove PAUSED as well. Thanks for pointing it out.

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
File remoting/protocol/webrtc_video_capturer_adapter.h (right):

https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrt...
remoting/protocol/webrtc_video_capturer_adapter.h:60: bool PauseCapturer(bool
pause);
On 2016/03/23 18:08:03, Sergey Ulanov wrote:
> Since this is not part of the VideoCapturer interface anymore it needs to be
> moved, e.g. after SetSizeCallback()

Done.

[Sergey Ulanov, 2016-03-23 21:35:35]

lgtm

[perkj_chrome, 2016-03-24 07:41:01]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2016-03-24 07:41:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745923002/80001

[commit-bot: I haz the power, 2016-03-24 08:25:04]

Description was changed from

==========
Remove use of deprecated methods to cricket::VideoCapturer in
WebrtcVideoCapturerAdapter

VideoCapturer::Pause is never used in the webrtc code base.
SignalgVideoFrame should also be removed and replaced with normal method call to
VideoCapturer::OnFrame.

BUG=webrtc:5426
==========

to

==========
Remove use of deprecated methods to cricket::VideoCapturer in
WebrtcVideoCapturerAdapter

VideoCapturer::Pause is never used in the webrtc code base.
SignalgVideoFrame should also be removed and replaced with normal method call to
VideoCapturer::OnFrame.

BUG=webrtc:5426
==========

[commit-bot: I haz the power, 2016-03-24 08:25:05]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-03-24 08:26:02]

Description was changed from

==========
Remove use of deprecated methods to cricket::VideoCapturer in
WebrtcVideoCapturerAdapter

VideoCapturer::Pause is never used in the webrtc code base.
SignalgVideoFrame should also be removed and replaced with normal method call to
VideoCapturer::OnFrame.

BUG=webrtc:5426
==========

to

==========
Remove use of deprecated methods to cricket::VideoCapturer in
WebrtcVideoCapturerAdapter

VideoCapturer::Pause is never used in the webrtc code base.
SignalgVideoFrame should also be removed and replaced with normal method call to
VideoCapturer::OnFrame.

BUG=webrtc:5426

Committed: https://crrev.com/1f29be6be1b2671cc73cd8f83045b7e4a208216b
Cr-Commit-Position: refs/heads/master@{#383040}
==========

[commit-bot: I haz the power, 2016-03-24 08:26:04]

Patchset 4 (id:??) landed as
https://crrev.com/1f29be6be1b2671cc73cd8f83045b7e4a208216b
Cr-Commit-Position: refs/heads/master@{#383040}