Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1745923002: Remove use of deprecated methods to cricket::VideoCapturer in WebrtcVideoCapturerAdapter (Closed)

Created:
4 years, 9 months ago by perkj_chrome
Modified:
4 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of deprecated methods to cricket::VideoCapturer in WebrtcVideoCapturerAdapter VideoCapturer::Pause is never used in the webrtc code base. SignalgVideoFrame should also be removed and replaced with normal method call to VideoCapturer::OnFrame. BUG=webrtc:5426 Committed: https://crrev.com/1f29be6be1b2671cc73cd8f83045b7e4a208216b Cr-Commit-Position: refs/heads/master@{#383040}

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Addressed comments. #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M remoting/protocol/webrtc_video_capturer_adapter.h View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_video_capturer_adapter.cc View 1 2 3 3 chunks +6 lines, -14 lines 0 comments Download
M remoting/protocol/webrtc_video_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
perkj_chrome
Please?
4 years, 9 months ago (2016-03-23 14:45:05 UTC) #3
Sergey Ulanov
No https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrtc_video_capturer_adapter.cc File remoting/protocol/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/1745923002/diff/20001/remoting/protocol/webrtc_video_capturer_adapter.cc#newcode74 remoting/protocol/webrtc_video_capturer_adapter.cc:74: // Similar to the base class implementation with ...
4 years, 9 months ago (2016-03-23 18:08:03 UTC) #4
Sergey Ulanov
On 2016/03/23 18:08:03, Sergey Ulanov wrote: > No Sorry, didn't mean to write this "No", ...
4 years, 9 months ago (2016-03-23 18:16:10 UTC) #5
perkj_chrome
Fingers slip so easily :-) Did you btw see my question for you in https://codereview.chromium.org/1821153003/ ...
4 years, 9 months ago (2016-03-23 20:11:45 UTC) #7
Sergey Ulanov
lgtm
4 years, 9 months ago (2016-03-23 21:35:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745923002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745923002/80001
4 years, 9 months ago (2016-03-24 07:41:12 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 9 months ago (2016-03-24 08:25:05 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 08:26:04 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1f29be6be1b2671cc73cd8f83045b7e4a208216b
Cr-Commit-Position: refs/heads/master@{#383040}

Powered by Google App Engine
This is Rietveld 408576698