Issue 174592: Fix DiskCacheEntryTest.MemoryOnlyDoomSparseEntry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174592: Fix DiskCacheEntryTest.MemoryOnlyDoomSparseEntry (Closed)

Created:
11 years, 4 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix DiskCacheEntryTest.MemoryOnlyDoomSparseEntry BUG=12258 TEST=DiskCacheEntryTest.MemoryOnlyDoomSparseEntry The sequence that caused this test to break was to doom to the entry while it is still opened. Since closing the parent entry only delete itself and then child entries are not cleaned up. This is corrected by using InternalDoom() for destruction. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24594

Patch Set 1 #

Patch Set 2 : cache only #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/disk_cache/entry_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/disk_cache/mem_entry_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages