Add histograms presubmit check for UseCounter.h

tools/metrics/histograms/update_histogram_enum.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Updates enums in histograms.xml file with values read from provided C++ enum.
 
 If the file was pretty-printed, the updated version is pretty-printed too.
 """
 
 import logging
@@ skipping 124 matching lines @@
 
   # Add comments at the top.
   for comment in new_comments:
     enum_node.appendChild(comment)
 
   # Add in the new enums.
   for value in sorted(new_item_nodes.iterkeys()):
     enum_node.appendChild(new_item_nodes[value])
 
 
+def HistogramNeedsUpdate(histogram_enum_name, source_enum_path, start_marker,
+                         end_marker):
+  Log('Reading histogram enum definition from "{0}".'.format(source_enum_path))
+  source_enum_values = ReadHistogramValues(source_enum_path, start_marker,
+                                           end_marker)
+
+  HISTOGRAMS_PATH = path_util.GetHistogramsFile()
+
+  Log('Reading existing histograms from "{0}".'.format(HISTOGRAMS_PATH))
+  with open(HISTOGRAMS_PATH, 'rb') as f:
+    histograms_doc = minidom.parse(f)
+    f.seek(0)
+    xml = f.read()
+
+  Log('Comparing histograms enum with new enum definition.')
+  UpdateHistogramDefinitions(histogram_enum_name, source_enum_values,
+                             source_enum_path, histograms_doc)
+
+  new_xml = print_style.GetPrintStyle().PrettyPrintNode(histograms_doc)

[Ilya Sherman, 2016/03/02 00:59:29]

It looks like you copy/pasted lines 151-163 here.  Please factor out this shared
code into a helper function.

[suzyh_UTC10 (ex-contributor), 2016/03/02 03:23:49]

Done. It's a bit messy, but I haven't been able to think of a better way of
organizing it, given that UpdateHistogramEnum, ReadHistogramValues and
UpdateHistogramFromDict are all used by other code.

[Ilya Sherman, 2016/03/02 23:18:46]

Thanks!  This is the structure that I was thinking of as well -- I agree that
it's a bit awkward, but IMO it's still nicer than duplicating the code =)

+
+  return xml != new_xml
+
+
 def UpdateHistogramFromDict(histogram_enum_name, source_enum_values,
                             source_enum_path):
   """Updates |histogram_enum_name| enum in histograms.xml file with values
   from the {value: 'key'} dictionary |source_enum_values|. A comment is added
   to histograms.xml citing that the values in |histogram_enum_name| were
   sourced from |source_enum_path|.
   """
   HISTOGRAMS_PATH = path_util.GetHistogramsFile()
 
   Log('Reading existing histograms from "{0}".'.format(HISTOGRAMS_PATH))
@@ skipping 30 matching lines @@
       start_marker: A regular expression that matches the start of the C++ enum.
       end_marker: A regular expression that matches the end of the C++ enum.
   """
 
   Log('Reading histogram enum definition from "{0}".'.format(source_enum_path))
   source_enum_values = ReadHistogramValues(source_enum_path, start_marker,
                                            end_marker)
 
   UpdateHistogramFromDict(histogram_enum_name, source_enum_values,
       source_enum_path)