Introduce GpuVideoDecodeAcceleratorFactory.

content/public/common/gpu_video_decode_accelerator_factory.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_COMMON_GPU_VIDEO_DECODE_ACCELERATOR_FACTORY_H_
+#define CONTENT_PUBLIC_COMMON_GPU_VIDEO_DECODE_ACCELERATOR_FACTORY_H_
+
+#include "base/threading/thread_checker.h"
+#include "content/common/content_export.h"
+#include "content/public/common/gpu_video_decode_accelerator_helpers.h"
+#include "gpu/config/gpu_info.h"
+#include "media/video/video_decode_accelerator.h"
+
+namespace content {
+
+// This factory allows creation of VideoDecodeAccelerator implementations,
+// providing the most applicable VDA for current platform and given
+// configuration. To be used in GPU process only.

[jam, 2016/03/14 15:58:29]

then this should be in content/public/gpu

+class CONTENT_EXPORT GpuVideoDecodeAcceleratorFactory {
+ public:
+  ~GpuVideoDecodeAcceleratorFactory();
+
+  // Create a factory capable of producing VDA instances for current platform.
+  static scoped_ptr<GpuVideoDecodeAcceleratorFactory> Create(
+      const gpu_vda::GetGLContextCallback& get_gl_context_cb,
+      const gpu_vda::MakeGLContextCurrentCallback& make_context_current_cb,
+      const gpu_vda::BindGLImageCallback& bind_image_cb);
+
+  static scoped_ptr<GpuVideoDecodeAcceleratorFactory> CreateWithGLES2Decoder(
+      const gpu_vda::GetGLContextCallback& get_gl_context_cb,
+      const gpu_vda::MakeGLContextCurrentCallback& make_context_current_cb,
+      const gpu_vda::BindGLImageCallback& bind_image_cb,
+      const gpu_vda::GetGLES2DecoderCallback& get_gles2_decoder_cb);
+
+  // Return decoder capabilities supported on the current platform.
+  static gpu::VideoDecodeAcceleratorCapabilities GetDecoderCapabilities();
+
+  // Create a VDA for the current platform for |client| with the given |config|.
+  // Return nullptr on failure.
+  scoped_ptr<media::VideoDecodeAccelerator> CreateVDA(
+      media::VideoDecodeAccelerator::Client* client,
+      const media::VideoDecodeAccelerator::Config& config);
+
+ private:
+  GpuVideoDecodeAcceleratorFactory(

[jam, 2016/03/14 15:58:29]

this section in private is against the content api guidelines:
https://www.chromium.org/developers/content-module/content-api

[jam, 2016/03/16 20:56:43]

this comment is still not addressed.

why is there a private section instead of putting these in an annonymous
namespace in the implementation (for the methods) and using lazy instance for
these members?

[Pawel Osciak, 2016/03/17 11:15:16]

Sorry somehow missed this. Created a GpuVideoDecodeAcceleratorFactoryImpl, would
that work?

[jam, 2016/03/17 15:43:26]

I'm not sure I understand the point of having both
GpuVideoDecodeAcceleratorFactory and GpuVideoDecodeAcceleratorFactoryImpl that
each contain static methods? i.e. the impl file just duplicates the 4 static
methods and adds private members that are only used in impl.cc. those static
members could instead be in the cc file containing the implementation of the
public static methods.

normally we have "impl" files because we have a Foo interface and FooImpl
implementation hidden behind content. in this case with static methods, the
usual pattern for that is to declare them in content/public/bar/foo.h. and then
implement them in content/bar/foo.cc.

[jam, 2016/03/18 01:18:56]

ignore this comment, and thanks for the explanation over IM
I totally missed the non-static method, sorry

+      const gpu_vda::GetGLContextCallback& get_gl_context_cb,
+      const gpu_vda::MakeGLContextCurrentCallback& make_context_current_cb,
+      const gpu_vda::BindGLImageCallback& bind_image_cb,
+      const gpu_vda::GetGLES2DecoderCallback& get_gles2_decoder_cb);
+
+  scoped_ptr<media::VideoDecodeAccelerator> CreateDXVAVDA() const;
+  scoped_ptr<media::VideoDecodeAccelerator> CreateV4L2VDA() const;
+  scoped_ptr<media::VideoDecodeAccelerator> CreateV4L2SVDA() const;
+  scoped_ptr<media::VideoDecodeAccelerator> CreateVaapiVDA() const;
+  scoped_ptr<media::VideoDecodeAccelerator> CreateVTVDA() const;
+  scoped_ptr<media::VideoDecodeAccelerator> CreateOzoneVDA() const;
+  scoped_ptr<media::VideoDecodeAccelerator> CreateAndroidVDA() const;
+
+  const gpu_vda::GetGLContextCallback get_gl_context_cb_;
+  const gpu_vda::MakeGLContextCurrentCallback make_context_current_cb_;
+  const gpu_vda::BindGLImageCallback bind_image_cb_;
+  const gpu_vda::GetGLES2DecoderCallback& get_gles2_decoder_cb_;
+
+  base::ThreadChecker thread_checker_;
+
+  DISALLOW_IMPLICIT_CONSTRUCTORS(GpuVideoDecodeAcceleratorFactory);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_COMMON_GPU_VIDEO_DECODE_ACCELERATOR_FACTORY_H_