Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1745863002: [wasm] Allocate WasmModule and WasmModuleInstance vectors inline. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
bradnelson, bradn, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Allocate WasmModule and WasmModuleInstance vectors inline. R=bradnelson@chromium.org,ahaas@chromium.org BUG= Committed: https://crrev.com/008888c8cb8dfdadd320894326384a316e3d0841 Cr-Commit-Position: refs/heads/master@{#34351}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -229 lines) Patch
M src/compiler/wasm-compiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/wasm/ast-decoder.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 11 chunks +29 lines, -36 lines 0 comments Download
M src/wasm/wasm-module.h View 1 4 chunks +18 lines, -21 lines 0 comments Download
M src/wasm/wasm-module.cc View 16 chunks +29 lines, -56 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 7 chunks +18 lines, -30 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +12 lines, -16 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 13 chunks +66 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
titzer
4 years, 9 months ago (2016-02-28 15:18:51 UTC) #1
bradn
lgtm
4 years, 9 months ago (2016-02-28 19:02:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745863002/20001
4 years, 9 months ago (2016-02-28 19:02:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-28 19:04:14 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-28 19:05:49 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/008888c8cb8dfdadd320894326384a316e3d0841
Cr-Commit-Position: refs/heads/master@{#34351}

Powered by Google App Engine
This is Rietveld 408576698