Make audio and video in sync while playback rate != 1.0...

chrome/renderer/media/audio_renderer_impl.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.  Use of this
 // source code is governed by a BSD-style license that can be found in the
 // LICENSE file.
 
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/audio_message_filter.h"
 #include "chrome/renderer/media/audio_renderer_impl.h"
 #include "chrome/renderer/render_view.h"
 #include "chrome/renderer/render_thread.h"
 #include "media/base/filter_host.h"
@@ skipping 273 matching lines @@
       base::TimeDelta receive_latency = current_time - request_timestamp_;
 
       // If the receive latency is too much it may offset all the delay.
       if (receive_latency >= request_delay) {
         request_delay = base::TimeDelta();
       } else {
         request_delay -= receive_latency;
       }
     }
 
+    // Finally we need to adjust the delay according to playback rate.
+    if (GetPlaybackRate() != 1.0f) {

[fbarchard, 2009/08/27 03:21:18]

shouldnt you do this code within the 
if (current_time > request_timestamp_) {
above?

+      request_delay = base::TimeDelta::FromMicroseconds(
+          static_cast<int64>(request_delay.InMicroseconds() *

[scherkus (not reviewing), 2009/08/26 23:59:00]

you may want to be explicit in how the value is rounded i.e. ceil()

+                             GetPlaybackRate()));
+    }
+
     size_t filled = FillBuffer(static_cast<uint8*>(shared_memory_->memory()),
                                shared_memory_size_,
                                request_delay);
     // TODO(hclam): we should try to fill in the buffer as much as possible.
     if (filled > 0) {
       pending_request_ = false;
       request_delay_ = base::TimeDelta();
       request_timestamp_ = base::Time();
       // Then tell browser process we are done filling into the buffer.
       filter_->Send(
           new ViewHostMsg_NotifyAudioPacketReady(0, stream_id_, filled));
 
       if (prerolling_) {
         // We have completed prerolling.
         if (filled > preroll_bytes_) {
           prerolling_ = false;
           preroll_bytes_ = 0;
           filter_->Send(new ViewHostMsg_PlayAudioStream(0, stream_id_));
         } else {
           preroll_bytes_ -= filled;
         }
       }
     }
   }
 }