Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3328)

Unified Diff: chrome/browser/metrics/perf/perf_provider_chromeos.h

Issue 1745723002: Fix ChromeOS-only static initializers from the last 5 months. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, address dhsharp comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/perf/perf_provider_chromeos.h
diff --git a/chrome/browser/metrics/perf/perf_provider_chromeos.h b/chrome/browser/metrics/perf/perf_provider_chromeos.h
index 6f2c7e744711bc46e61e272bdb378c16cb1af989..68d1cd79b908705679f9fd06e7bda6a73e991dcc 100644
--- a/chrome/browser/metrics/perf/perf_provider_chromeos.h
+++ b/chrome/browser/metrics/perf/perf_provider_chromeos.h
@@ -61,7 +61,7 @@ class PerfProvider : public base::NonThreadSafe,
}
private:
- TriggerParams() = default; // POD
+ TriggerParams() = delete;
// Limit the number of profiles collected.
int64_t sampling_factor_;
@@ -71,6 +71,8 @@ class PerfProvider : public base::NonThreadSafe,
TimeDeltaInternalType max_collection_delay_;
};
+ CollectionParams();
+
CollectionParams(base::TimeDelta collection_duration,
base::TimeDelta periodic_interval,
TriggerParams resume_from_suspend,
@@ -104,8 +106,6 @@ class PerfProvider : public base::NonThreadSafe,
}
private:
- CollectionParams() = default; // POD
-
// Time perf is run for.
TimeDeltaInternalType collection_duration_;
@@ -117,6 +117,8 @@ class PerfProvider : public base::NonThreadSafe,
// Parameters for RESUME_FROM_SUSPEND and RESTORE_SESSION collections:
TriggerParams resume_from_suspend_;
TriggerParams restore_session_;
+
+ DISALLOW_COPY_AND_ASSIGN(CollectionParams);
};
// Parses a PerfDataProto from serialized data |perf_data|, if it exists.
@@ -155,8 +157,6 @@ class PerfProvider : public base::NonThreadSafe,
}
private:
- static const CollectionParams kDefaultParameters;
-
// Class that listens for changes to the login state. When a normal user logs
// in, it updates PerfProvider to start collecting data.
class LoginObserver : public chromeos::LoginState::Observer {
« no previous file with comments | « chrome/browser/chromeos/drive/download_handler.cc ('k') | chrome/browser/metrics/perf/perf_provider_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698