Auto-project on distinct inequality fields.

Auto-project on distinct inequality fields.

BUG=

Committed: https://github.com/luci/gae/commit/63bef7c9b704957bc62cf3691b59c72bcfe544ce

[iannucci, 2016-02-27 00:58:50]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2016-02-27 00:58:51]

In query.go on line 576, try adding

		// If we're DISTINCT && have an inequality filter, we must project that
		// inequality property as well.
		if ret.distinct && ret.ineqFiltProp != "" && !q.project.Has(ret.ineqFiltProp)
{
			ret.project = append([]string{ret.ineqFiltProp}, ret.project...)
		}

And I think your tests should pass

https://chromiumcodereview.appspot.com/1745703002/diff/1/service/datastore/fi...
File service/datastore/finalized_query.go (right):

https://chromiumcodereview.appspot.com/1745703002/diff/1/service/datastore/fi...
service/datastore/finalized_query.go:84: ret = append(ret, q.project...)
ditch this whole thing

[iannucci, 2016-02-27 01:02:02]

https://chromiumcodereview.appspot.com/1745703002/diff/1/impl/prod/everything...
File impl/prod/everything_test.go (right):

https://chromiumcodereview.appspot.com/1745703002/diff/1/impl/prod/everything...
impl/prod/everything_test.go:214: So(count, ShouldEqual, 4)
We should have a test like this one for impl/memory too

https://chromiumcodereview.appspot.com/1745703002/diff/1/service/datastore/qu...
File service/datastore/query_test.go (right):

https://chromiumcodereview.appspot.com/1745703002/diff/1/service/datastore/qu...
service/datastore/query_test.go:150: "SELECT DISTINCT `bar` FROM `Foo` WHERE
`foo` >= 10 ORDER BY `foo`, `bar`, `__key__`",
this is wrong though, it should DISTINCT `foo`, `bar`

[iannucci, 2016-02-27 01:04:26]

https://chromiumcodereview.appspot.com/1745703002/diff/20001/service/datastor...
File service/datastore/query.go (right):

https://chromiumcodereview.appspot.com/1745703002/diff/20001/service/datastor...
service/datastore/query.go:582: }
ah... yeah it technically works here too, I was thinking it could be in the
previous if statement tho

https://chromiumcodereview.appspot.com/1745703002/diff/20001/service/datastor...
File service/datastore/query_test.go (right):

https://chromiumcodereview.appspot.com/1745703002/diff/20001/service/datastor...
service/datastore/query_test.go:150: "SELECT DISTINCT `bar`, `foo` FROM `Foo`
WHERE `foo` >= 10 ORDER BY `foo`, `bar`, `__key__`",
hm... this should be 'foo', 'bar' though :(

[iannucci, 2016-02-27 01:16:46]

lgtm, the project sort order doesn't matter, it's Finalize doing a sort.Strings
on it.

[iannucci, 2016-02-27 01:16:49]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2016-02-27 01:16:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745703002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745703002/40001

[commit-bot: I haz the power, 2016-02-27 01:22:08]

Description was changed from

==========
Auto-project on distinct inequality fields.

BUG=
==========

to

==========
Auto-project on distinct inequality fields.

BUG=

Committed:
https://github.com/luci/gae/commit/63bef7c9b704957bc62cf3691b59c72bcfe544ce
==========

[commit-bot: I haz the power, 2016-02-27 01:22:09]

Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/63bef7c9b704957bc62cf3691b59c72bcfe544ce