Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 17457002: Files.app: Set border-outset for image-border of buttons. (Closed)

Created:
7 years, 6 months ago by yoshiki
Modified:
7 years, 6 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Set border-outset for image-border of buttons. BUG=251685 R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207792

Patch Set 1 #

Patch Set 2 : address comment #

Patch Set 3 : address comment #

Patch Set 4 : address comment #

Patch Set 5 : rebase #

Patch Set 6 : remove white lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M chrome/browser/resources/file_manager/css/common.css View 1 2 3 4 5 7 chunks +16 lines, -19 lines 0 comments Download
M chrome/browser/resources/file_manager/css/file_manager.css View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
yoshiki
@hirono: could you take a look? Thanks.
7 years, 6 months ago (2013-06-19 10:40:11 UTC) #1
hirono
On 2013/06/19 10:40:11, yoshiki wrote: > @hirono: could you take a look? Thanks. It seems ...
7 years, 6 months ago (2013-06-19 12:34:58 UTC) #2
yoshiki
On 2013/06/19 12:34:58, hirono wrote: > On 2013/06/19 10:40:11, yoshiki wrote: > > @hirono: could ...
7 years, 6 months ago (2013-06-20 03:59:01 UTC) #3
hirono
On 2013/06/20 03:59:01, yoshiki wrote: > On 2013/06/19 12:34:58, hirono wrote: > > On 2013/06/19 ...
7 years, 6 months ago (2013-06-20 04:14:59 UTC) #4
yoshiki
On 2013/06/20 04:14:59, hirono wrote: > On 2013/06/20 03:59:01, yoshiki wrote: > > On 2013/06/19 ...
7 years, 6 months ago (2013-06-20 04:52:52 UTC) #5
hirono
On 2013/06/20 04:52:52, yoshiki wrote: > On 2013/06/20 04:14:59, hirono wrote: > > On 2013/06/20 ...
7 years, 6 months ago (2013-06-20 05:54:10 UTC) #6
yoshiki
On 2013/06/20 05:54:10, hirono wrote: > On 2013/06/20 04:52:52, yoshiki wrote: > > On 2013/06/20 ...
7 years, 6 months ago (2013-06-20 06:27:40 UTC) #7
hirono
On 2013/06/20 06:27:40, yoshiki wrote: > On 2013/06/20 05:54:10, hirono wrote: > > On 2013/06/20 ...
7 years, 6 months ago (2013-06-20 07:02:40 UTC) #8
yoshiki
thanks!
7 years, 6 months ago (2013-06-21 04:52:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/17457002/22001
7 years, 6 months ago (2013-06-21 04:53:34 UTC) #10
yoshiki
7 years, 6 months ago (2013-06-21 10:29:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #6 manually as r207792 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698