core/src/fpdfapi/fpdf_page/fpdf_page.cpp - Issue 1745683002: Fixup FX_RECT and FX_SMALL_RECT classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page.cpp

Issue 1745683002: Fixup FX_RECT and FX_SMALL_RECT classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, Dan's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page.cpp

index f05c4bea92a1f8aa9c9ddcc80b155aaee1f3328d..301fca89697d681dcc41b0546dd9db23978d7902 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page.cpp

@@ -251,8 +251,7 @@ void CPDF_TextObject::CalcPositionData(FX_FLOAT* pTextAdvanceX,

}

m_pCharPos[i - 1] = curpos;

}

- FX_RECT char_rect;

- pFont->GetCharBBox(charcode, char_rect, level);

+ FX_RECT char_rect = pFont->GetCharBBox(charcode, level);

FX_FLOAT charwidth;

if (!bVertWriting) {

if (min_y > char_rect.top) {