Polish the look of Linux extension shelf.

Polish the look of Linux extension shelf.

TEST=none
http://crbug.com/16759

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24539

[Elliot Glaysher, 2009-08-26 21:42:39]

Generally LGTM, but one thing you might want to fix:

http://codereview.chromium.org/174564/diff/1/2
File chrome/browser/gtk/extension_shelf_gtk.cc (right):

http://codereview.chromium.org/174564/diff/1/2#newcode173
Line 173: gtk_widget_modify_bg(event_box_.get(), GTK_STATE_NORMAL,
&kBackgroundColor);
A question: Why is this a hardcoded value instead of NULL in gtk theme mode and
COLOR_TOOLBAR in chrome theme mode?

[Paweł Hajdan Jr., 2009-08-26 21:48:27]

On 2009/08/26 21:42:39, Elliot Glaysher wrote:
> Generally LGTM, but one thing you might want to fix:
> 
> http://codereview.chromium.org/174564/diff/1/2
> File chrome/browser/gtk/extension_shelf_gtk.cc (right):
> 
> http://codereview.chromium.org/174564/diff/1/2#newcode173
> Line 173: gtk_widget_modify_bg(event_box_.get(), GTK_STATE_NORMAL,
> &kBackgroundColor);
> A question: Why is this a hardcoded value instead of NULL in gtk theme mode
and
> COLOR_TOOLBAR in chrome theme mode?

Windows ExtensionShelf does the same. It's not perfect, but at least consistent.

[Elliot Glaysher, 2009-08-26 21:50:28]

On 2009/08/26 21:48:27, Paweł Hajdan Jr. wrote:
> On 2009/08/26 21:42:39, Elliot Glaysher wrote:
> > Generally LGTM, but one thing you might want to fix:
> > 
> > http://codereview.chromium.org/174564/diff/1/2
> > File chrome/browser/gtk/extension_shelf_gtk.cc (right):
> > 
> > http://codereview.chromium.org/174564/diff/1/2#newcode173
> > Line 173: gtk_widget_modify_bg(event_box_.get(), GTK_STATE_NORMAL,
> > &kBackgroundColor);
> > A question: Why is this a hardcoded value instead of NULL in gtk theme mode
> and
> > COLOR_TOOLBAR in chrome theme mode?
> 
> Windows ExtensionShelf does the same. It's not perfect, but at least
consistent.

Ok, LGTM then.