components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java - Issue 1745623002: Fix SELinux violation when opening Chrome on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

Issue 1745623002: Fix SELinux violation when opening Chrome on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@movetestonlytofixture

Patch Set: nyquist comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/java/src/org/chromium/base/PathUtils.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java ('k') | components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

diff --git a/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java b/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

index 39f10a7f90824625b20f779a65afadefb097c29e..462d515cb995e9c9506802552fc2a22667765b86 100644

--- a/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

+++ b/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java

@@ -118,6 +118,8 @@ public class GCMDriver {

}.execute();

}

+ // The caller of this function is responsible for setting the PathUtils Private Data Directory

+ // Suffix before calling onMessageReceived().

public static void onMessageReceived(Context context, final String appId, final Bundle extras) {

// TODO(johnme): Store message and redeliver later if Chrome is killed before delivery.

ThreadUtils.assertOnUiThread();