chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java - Issue 1745623002: Fix SELinux violation when opening Chrome on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Issue 1745623002: Fix SELinux violation when opening Chrome on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@movetestonlytofixture

Patch Set: nyquist comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/java/src/org/chromium/base/PathUtils.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

index f5d133dd346aa85d5713d2a7a856cea133385fc8..65eb683667b2b570e6ec1247cda1f3cfce47890d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

@@ -36,6 +36,7 @@ import android.view.ViewGroup;

import android.widget.EditText;

import android.widget.ImageButton;

+import org.chromium.base.PathUtils;

import org.chromium.base.ThreadUtils;

import org.chromium.base.library_loader.LibraryLoader;

import org.chromium.base.library_loader.LibraryProcessType;

@@ -101,6 +102,7 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {

private static final String TEST_PAGE = "/chrome/test/data/android/google.html";

private static final String TEST_PAGE_2 = "/chrome/test/data/android/test.html";

private static final String TEST_MENU_TITLE = "testMenuTitle";

+ private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "chrome";

private static int sIdToIncrement = 1;

@@ -116,6 +118,8 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {

getInstrumentation().getContext(), Environment.getExternalStorageDirectory());

mTestPage = mTestServer.getURL(TEST_PAGE);

mTestPage2 = mTestServer.getURL(TEST_PAGE_2);

+ PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX,

+ getInstrumentation().getTargetContext().getApplicationContext());

LibraryLoader.get(LibraryProcessType.PROCESS_BROWSER)

.ensureInitialized(getInstrumentation().getTargetContext().getApplicationContext());

}