Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1745613002: Switch float arrays to vecs for conical gradients (Closed)

Created:
4 years, 10 months ago by jvanverth1
Modified:
4 years, 10 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -24 lines) Patch
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +15 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jvanverth1
A couple of obvious cases where we don't need float arrays.
4 years, 10 months ago (2016-02-26 21:23:42 UTC) #3
bsalomon
lgtm
4 years, 10 months ago (2016-02-26 21:30:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745613002/1
4 years, 10 months ago (2016-02-26 21:48:45 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 21:58:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de11ee41b39d7c382e11636a47c39470426c9325

Powered by Google App Engine
This is Rietveld 408576698