Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: content/browser/leveldb_wrapper_impl.cc

Issue 1745603002: Switch LevelDBWrapper::GetAll to use the new Mojo sync IPC mechanism. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/leveldb_wrapper_impl.h ('k') | content/browser/storage_partition_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/leveldb_wrapper_impl.cc
diff --git a/content/browser/level_db_wrapper_impl.cc b/content/browser/leveldb_wrapper_impl.cc
similarity index 79%
rename from content/browser/level_db_wrapper_impl.cc
rename to content/browser/leveldb_wrapper_impl.cc
index d2f1b3e19b3e9198eb8f0aa4ab728ecf6278ab7c..137e5c42fe6a5f43d2a370a0a30b877caaa1b962 100644
--- a/content/browser/level_db_wrapper_impl.cc
+++ b/content/browser/leveldb_wrapper_impl.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/browser/level_db_wrapper_impl.h"
+#include "content/browser/leveldb_wrapper_impl.h"
#include "base/bind.h"
@@ -15,14 +15,11 @@ LevelDBWrapperImpl::LevelDBWrapperImpl(
&LevelDBWrapperImpl::OnConnectionError, base::Unretained(this)));
}
-void LevelDBWrapperImpl::Bind(mojo::InterfaceRequest<LevelDBWrapper> request,
- LevelDBObserverPtr observer) {
- // TODO(jam): store observer and call it when changes occur.
+void LevelDBWrapperImpl::Bind(mojo::InterfaceRequest<LevelDBWrapper> request) {
bindings_.AddBinding(this, std::move(request));
}
LevelDBWrapperImpl::~LevelDBWrapperImpl() {
- no_bindings_callback_.Run();
}
void LevelDBWrapperImpl::Put(mojo::Array<uint8_t> key,
@@ -36,15 +33,19 @@ void LevelDBWrapperImpl::Delete(mojo::Array<uint8_t> key,
const DeleteCallback& callback) {
}
-void LevelDBWrapperImpl::DeleteAll(const mojo::String& source,
+void LevelDBWrapperImpl::DeleteAll(LevelDBObserverPtr observer,
+ const mojo::String& source,
const DeleteAllCallback& callback) {
+ // TODO(jam): store observer and call it when changes occur.
}
void LevelDBWrapperImpl::Get(mojo::Array<uint8_t> key,
const GetCallback& callback) {
}
-void LevelDBWrapperImpl::GetAll(const GetAllCallback& callback) {
+void LevelDBWrapperImpl::GetAll(LevelDBObserverPtr observer,
+ const GetAllCallback& callback) {
+ // TODO(jam): store observer and call it when changes occur.
}
void LevelDBWrapperImpl::OnConnectionError() {
« no previous file with comments | « content/browser/leveldb_wrapper_impl.h ('k') | content/browser/storage_partition_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698