Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 174553004: Compile GURL for PNaCl (Closed)

Created:
6 years, 10 months ago by Sergey Ulanov
Modified:
6 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Compile GURL for PNaCl The new url_nacl target compiles GURL for PNaCl. BUG=276739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252886

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -38 lines) Patch
M url/url.gyp View 3 chunks +7 lines, -38 lines 0 comments Download
A url/url_nacl.gyp View 1 1 chunk +37 lines, -0 lines 0 comments Download
A url/url_srcs.gypi View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Sergey Ulanov
6 years, 10 months ago (2014-02-21 01:57:56 UTC) #1
brettw
lgtm
6 years, 10 months ago (2014-02-22 18:42:07 UTC) #2
brettw
lgtm lgtm
6 years, 10 months ago (2014-02-22 18:42:07 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-22 18:54:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/174553004/40001
6 years, 10 months ago (2014-02-22 18:56:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 20:00:15 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268534
6 years, 10 months ago (2014-02-22 20:00:15 UTC) #7
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-23 01:01:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/174553004/40001
6 years, 10 months ago (2014-02-23 01:01:17 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-23 09:40:45 UTC) #10
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-24 05:18:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/174553004/40001
6 years, 10 months ago (2014-02-24 05:19:08 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 06:41:12 UTC) #14
Message was sent while issue was closed.
Change committed as 252886

Powered by Google App Engine
This is Rietveld 408576698