Issue 174551: Enable welcome page for non-windows platforms....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174551: Enable welcome page for non-windows platforms.... (Closed)

Created:
11 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
cpu_(ooo_6.6-7.5), Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable welcome page for non-windows platforms. Later we may wish to customize the welcome page per platform (particularly for chrome os) but for now it looks helpful enough to be worth showing on the first run. BUG=20327 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24575

Patch Set 1 #

Patch Set 2 : compile #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -9 lines)			Patch
	M	chrome/browser/browser_init.cc	View	1	1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM, but maybe we should ask cpu why he made it windows-specific in the original ...

11 years, 4 months ago (2009-08-26 19:50:38 UTC) #2

cpu_(ooo_6.6-7.5)

11 years, 4 months ago (2009-08-26 22:29:26 UTC) #3

I have no clue why I didn't make it available to other platforms. I apologize.

LGTM.


On 2009/08/26 19:50:38, Evan Martin wrote:
> LGTM, but maybe we should ask cpu why he made it windows-specific in the
> original commit first

Expand Messages | Collapse Messages