Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1745463002: bluetooth: android: register for adapter on/off events followup. (Closed)

Created:
4 years, 9 months ago by scheib
Modified:
4 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: android: register for adapter on/off events followup. Followup changes requested by tedchoc on https://codereview.chromium.org/1711393002 BUG=543060 Committed: https://crrev.com/7b0ec9c32bf336aeb7e2563005c85122b2c58d3c Cr-Commit-Position: refs/heads/master@{#378022}

Patch Set 1 : Patch from https://codereview.chromium.org/1711393002/#ps40001 #

Patch Set 2 : Address tedchoc comments. #

Patch Set 3 : Merge tip of tree with perja's commit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M chrome/browser/ui/android/bluetooth_chooser_android.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/bluetooth_chooser_android.cc View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
scheib
In order to land for M50 branch point I've addressed tedchoc's comments on this new ...
4 years, 9 months ago (2016-02-26 20:25:14 UTC) #4
Ted C
patch delta - lgtm
4 years, 9 months ago (2016-02-26 21:08:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745463002/40001
4 years, 9 months ago (2016-02-26 21:46:50 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/56495)
4 years, 9 months ago (2016-02-26 22:05:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745463002/40001
4 years, 9 months ago (2016-02-26 22:36:21 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-02-26 23:24:32 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 23:25:47 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7b0ec9c32bf336aeb7e2563005c85122b2c58d3c
Cr-Commit-Position: refs/heads/master@{#378022}

Powered by Google App Engine
This is Rietveld 408576698