Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1745453002: More fixes for background compilation (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix release build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M runtime/vm/intermediate_language.h View 7 chunks +20 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/jit_optimizer.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 9 months ago (2016-02-26 18:32:44 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/1745453002/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/1745453002/diff/1/runtime/vm/intermediate_language.cc#newcode40 runtime/vm/intermediate_language.cc:40: #ifdef DEBUG also here? https://codereview.chromium.org/1745453002/diff/1/runtime/vm/intermediate_language.cc#newcode45 runtime/vm/intermediate_language.cc:45: #endif
4 years, 9 months ago (2016-02-26 18:39:15 UTC) #3
srdjan
https://codereview.chromium.org/1745453002/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/1745453002/diff/1/runtime/vm/intermediate_language.cc#newcode40 runtime/vm/intermediate_language.cc:40: On 2016/02/26 18:39:15, Florian Schneider wrote: > #ifdef DEBUG ...
4 years, 9 months ago (2016-02-26 18:43:44 UTC) #4
srdjan
4 years, 9 months ago (2016-02-26 18:58:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
20c17d9e414901d1be2f95e8c2eb4100ae853ca8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698