third_party/WebKit/Source/web/WebDevToolsAgentImpl.h - Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('K') | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

index 45326127b9f167a6270ab7d458162358cc7608dd..8e55d7f2549f876259cdc9dd0586e4af2645f20a 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

@@ -132,8 +132,8 @@ private:

void waitForCreateWindow(LocalFrame*) override;

// protocol::FrontendChannel implementation.

- void sendProtocolResponse(int sessionId, int callId, PassRefPtr<protocol::DictionaryValue> message) override;

- void sendProtocolNotification(PassRefPtr<protocol::DictionaryValue> message) override;

+ void sendProtocolResponse(int sessionId, int callId, PassOwnPtr<protocol::DictionaryValue> message) override;

+ void sendProtocolNotification(PassOwnPtr<protocol::DictionaryValue> message) override;

void flush() override;

// WebThread::TaskObserver implementation.

@@ -168,7 +168,7 @@ private:

InspectorAgentRegistry m_agents;

bool m_deferredAgentsInitialized;

- typedef Vector<std::pair<int, RefPtr<protocol::Value>>> NotificationQueue;

+ typedef Vector<std::pair<int, OwnPtr<protocol::Value>>> NotificationQueue;

NotificationQueue m_notificationQueue;

int m_sessionId;

String m_stateCookie;