Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1745413002: Clear stale elements in an undefined TypeName (Closed)

Created:
4 years, 9 months ago by skybrian
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clear stale elements in an unresolved TypeName BUG=https://github.com/dart-lang/sdk/issues/25855 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/09a7387740c172ccf2a4e81bac0617b49fd4fe8f

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : prereview cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -17 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 4 chunks +9 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 2 3 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
skybrian
4 years, 9 months ago (2016-03-01 00:21:41 UTC) #3
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-01 00:43:38 UTC) #4
skybrian
4 years, 9 months ago (2016-03-01 01:16:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
09a7387740c172ccf2a4e81bac0617b49fd4fe8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698