Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1745333002: Fix secureContexts layout tests (Closed)

Created:
4 years, 9 months ago by estark
Modified:
4 years, 9 months ago
Reviewers:
Mike West, alexmos
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix secureContexts layout tests As alexmos@ noticed in https://codereview.chromium.org/1723753002/, the secureContexts layout tests aren't very robust. They expect each frame to send exactly one message, but in fact the frames were sending messages to all of window.top, window.opener, and window.parent. This CL makes the frames only send messages to window.top; as far as I can tell there's no reason to send to window.opener or window.parent as well. BUG= Committed: https://crrev.com/c6688e12756110ff918cac35584ffca59e2023cb Cr-Commit-Position: refs/heads/master@{#378577}

Patch Set 1 #

Patch Set 2 : add unauthenticated.html to site-per-process expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/secureContexts/authenticated.html View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/secureContexts/resources/post-securecontext-status.html View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
estark
mkwst, alexmos, PTAL? This is a prequel to https://codereview.chromium.org/1723753002/ before I start revising that CL.
4 years, 9 months ago (2016-02-29 23:21:51 UTC) #2
estark
added unauthenticated.html failure to test expectations, since it now fails as expected with --site-per-process
4 years, 9 months ago (2016-02-29 23:27:10 UTC) #3
Mike West
LGTM.
4 years, 9 months ago (2016-03-01 13:45:22 UTC) #4
alexmos
LGTM
4 years, 9 months ago (2016-03-01 21:09:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745333002/20001
4 years, 9 months ago (2016-03-01 21:11:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 22:17:09 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 22:18:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6688e12756110ff918cac35584ffca59e2023cb
Cr-Commit-Position: refs/heads/master@{#378577}

Powered by Google App Engine
This is Rietveld 408576698