Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 174533002: QUIC - clarified comments for persisting crypto config per comments in (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)
Modified:
6 years, 10 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed wtc's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M net/quic/quic_crypto_client_stream.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
6 years, 10 months ago (2014-02-20 23:42:39 UTC) #1
wtc
Patch set 1 LGTM. https://codereview.chromium.org/174533002/diff/1/net/quic/quic_crypto_client_stream.cc File net/quic/quic_crypto_client_stream.cc (right): https://codereview.chromium.org/174533002/diff/1/net/quic/quic_crypto_client_stream.cc#newcode430 net/quic/quic_crypto_client_stream.cc:430: // and use the data ...
6 years, 10 months ago (2014-02-21 00:04:27 UTC) #2
ramant (doing other things)
https://codereview.chromium.org/174533002/diff/1/net/quic/quic_crypto_client_stream.cc File net/quic/quic_crypto_client_stream.cc (right): https://codereview.chromium.org/174533002/diff/1/net/quic/quic_crypto_client_stream.cc#newcode430 net/quic/quic_crypto_client_stream.cc:430: // and use the data from the disk cache ...
6 years, 10 months ago (2014-02-21 00:08:10 UTC) #3
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 10 months ago (2014-02-21 00:08:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/174533002/10002
6 years, 10 months ago (2014-02-21 00:10:03 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 04:04:42 UTC) #6
Message was sent while issue was closed.
Change committed as 252491

Powered by Google App Engine
This is Rietveld 408576698