Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1745273005: Add missing 'override' to BluetoothRemoteGattDescriptorWin destructor. (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
keybuk, hans, Nico, scheib
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing 'override' to BluetoothRemoteGattDescriptorWin destructor. BUG=82385 R=scheib@chromium.org, thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6a30b38f3e54e25db749a72d03d7a2e0acdd6119

Patch Set 1 #

Patch Set 2 : rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/bluetooth/bluetooth_remote_gatt_descriptor_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
dcheng
4 years, 9 months ago (2016-03-01 22:59:56 UTC) #2
Nico
lgtm if the "patch failure" is not interesting (i kind of feel like i wrote ...
4 years, 9 months ago (2016-03-01 23:06:52 UTC) #3
dcheng
(not sure why this patch isn't applying on the bots, the original patch https://codereview.chromium.org/1728163006 doesn't ...
4 years, 9 months ago (2016-03-01 23:07:25 UTC) #4
Nico
whoa we only have 3 clang slaves please don't schedule 5 try jobs (we'll have ...
4 years, 9 months ago (2016-03-01 23:10:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745273005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745273005/20001
4 years, 9 months ago (2016-03-01 23:11:07 UTC) #8
dcheng
On 2016/03/01 at 23:10:04, thakis wrote: > whoa we only have 3 clang slaves please ...
4 years, 9 months ago (2016-03-01 23:13:05 UTC) #10
scheib
LGTM
4 years, 9 months ago (2016-03-01 23:16:02 UTC) #12
dcheng
On 2016/03/01 at 23:13:05, dcheng wrote: > On 2016/03/01 at 23:10:04, thakis wrote: > > ...
4 years, 9 months ago (2016-03-01 23:16:05 UTC) #13
Nico
https://build.chromium.org/p/chromium.fyi/console?category=win%20clang is ablaze, can't get worse :-P hitting cq again.
4 years, 9 months ago (2016-03-01 23:28:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745273005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745273005/20001
4 years, 9 months ago (2016-03-01 23:28:58 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6a30b38f3e54e25db749a72d03d7a2e0acdd6119 Cr-Commit-Position: refs/heads/master@{#378627}
4 years, 9 months ago (2016-03-02 00:40:35 UTC) #18
dcheng
4 years, 9 months ago (2016-03-02 00:41:16 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6a30b38f3e54e25db749a72d03d7a2e0acdd6119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698