|
|
DescriptionAdd missing 'override' to BluetoothRemoteGattDescriptorWin destructor.
BUG=82385
R=scheib@chromium.org, thakis@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/6a30b38f3e54e25db749a72d03d7a2e0acdd6119
Patch Set 1 #Patch Set 2 : rebase? #
Messages
Total messages: 20 (8 generated)
dcheng@chromium.org changed reviewers: + hans@chromium.org, keybuk@chromium.org, thakis@chromium.org
lgtm if the "patch failure" is not interesting (i kind of feel like i wrote this patch beforeā¦)
(not sure why this patch isn't applying on the bots, the original patch https://codereview.chromium.org/1728163006 doesn't seem to have been reverted)
whoa we only have 3 clang slaves please don't schedule 5 try jobs (we'll have more slaves eventually, but that day is not today)
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1745273005/#ps20001 (title: "rebase?")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745273005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745273005/20001
The CQ bit was unchecked by dcheng@chromium.org
On 2016/03/01 at 23:10:04, thakis wrote: > whoa we only have 3 clang slaves please don't schedule 5 try jobs > > (we'll have more slaves eventually, but that day is not today) I'm not sure what happened, I checked one but it checked a bunch of them? Either way if the patch doesn't apply, I don't feel comfortable blindly landing this (I found this on a local build where I'm trying to fix something else)
scheib@chromium.org changed reviewers: + scheib@chromium.org
LGTM
On 2016/03/01 at 23:13:05, dcheng wrote: > On 2016/03/01 at 23:10:04, thakis wrote: > > whoa we only have 3 clang slaves please don't schedule 5 try jobs > > > > (we'll have more slaves eventually, but that day is not today) > > I'm not sure what happened, I checked one but it checked a bunch of them? Either way if the patch doesn't apply, I don't feel comfortable blindly landing this (I found this on a local build where I'm trying to fix something else) (Also, I don't think win_compile_* are clang bots too, are they?)
The CQ bit was checked by thakis@chromium.org
https://build.chromium.org/p/chromium.fyi/console?category=win%20clang is ablaze, can't get worse :-P hitting cq again.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745273005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745273005/20001
Message was sent while issue was closed.
Description was changed from ========== Add missing 'override' to BluetoothRemoteGattDescriptorWin destructor. BUG=82385 ========== to ========== Add missing 'override' to BluetoothRemoteGattDescriptorWin destructor. BUG=82385 R=scheib@chromium.org, thakis@chromium.org Committed: https://crrev.com/6a30b38f3e54e25db749a72d03d7a2e0acdd6119 Cr-Commit-Position: refs/heads/master@{#378627} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6a30b38f3e54e25db749a72d03d7a2e0acdd6119 Cr-Commit-Position: refs/heads/master@{#378627}
Message was sent while issue was closed.
Description was changed from ========== Add missing 'override' to BluetoothRemoteGattDescriptorWin destructor. BUG=82385 R=scheib@chromium.org, thakis@chromium.org Committed: https://crrev.com/6a30b38f3e54e25db749a72d03d7a2e0acdd6119 Cr-Commit-Position: refs/heads/master@{#378627} ========== to ========== Add missing 'override' to BluetoothRemoteGattDescriptorWin destructor. BUG=82385 R=scheib@chromium.org, thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6a30b38f3e54e25db749a72d03d7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 6a30b38f3e54e25db749a72d03d7a2e0acdd6119 (presubmit successful). |