Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1745263002: Cleanup some fsdk_common defines (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup some fsdk_common defines * FIELDFLAG_DONOTSPELLCHECK is defined on line 20. * 1 << 25 is used by FIELDFLAG_RICHTEXT already. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3fc97fff14c1496f1fa57240b1391dec42eb13d6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M fpdfsdk/include/fsdk_common.h View 1 chunk +1 line, -4 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-02-29 21:59:58 UTC) #2
Tom Sepez
https://codereview.chromium.org/1745263002/diff/1/fpdfsdk/include/fsdk_common.h File fpdfsdk/include/fsdk_common.h (left): https://codereview.chromium.org/1745263002/diff/1/fpdfsdk/include/fsdk_common.h#oldcode28 fpdfsdk/include/fsdk_common.h:28: #define FIELDFLAG_RADIOSINUNISON (1 << 25) Why'd this change? Are ...
4 years, 9 months ago (2016-02-29 22:37:49 UTC) #3
Tom Sepez
lgtm https://codereview.chromium.org/1745263002/diff/1/fpdfsdk/include/fsdk_common.h File fpdfsdk/include/fsdk_common.h (left): https://codereview.chromium.org/1745263002/diff/1/fpdfsdk/include/fsdk_common.h#oldcode28 fpdfsdk/include/fsdk_common.h:28: #define FIELDFLAG_RADIOSINUNISON (1 << 25) On 2016/02/29 22:37:49, ...
4 years, 9 months ago (2016-02-29 22:38:32 UTC) #4
dsinclair
4 years, 9 months ago (2016-03-01 13:56:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fc97fff14c1496f1fa57240b1391dec42eb13d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698