Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1745253002: [Worklets] Add basic debugging to main thread worklets. (Closed)

Created:
4 years, 9 months ago by ikilpatrick
Modified:
4 years, 9 months ago
Reviewers:
kinuko, pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Worklets] Add basic debugging to main thread worklets. This patch introduces MainThreadWorkletGlobalScope which lives in core/ This exposes accessing the parent LocalFrame for the MainThreadDebugger/devtools etc. Devtools JS interprets this as a page script, will need to follow up with a sane UI for worklets in devtools :) BUG=567358 Committed: https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e Cr-Commit-Position: refs/heads/master@{#382040}

Patch Set 1 #

Patch Set 2 : rebase off console. #

Patch Set 3 : working. #

Patch Set 4 : done. #

Patch Set 5 : . #

Total comments: 6

Patch Set 6 : rebase #

Patch Set 7 : fix comment. #

Patch Set 8 : fix non-oilpan build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -7 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 2 3 4 5 6 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 2 3 4 5 3 chunks +10 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
ikilpatrick
https://codereview.chromium.org/1745253002/diff/80001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h (right): https://codereview.chromium.org/1745253002/diff/80001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h#newcode16 third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h:16: class CORE_EXPORT MainThreadWorkletGlobalScope : public WorkerOrWorkletGlobalScope, public LocalFrameLifecycleObserver { ...
4 years, 9 months ago (2016-03-09 18:40:26 UTC) #3
pfeldman
https://codereview.chromium.org/1745253002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h File third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h (right): https://codereview.chromium.org/1745253002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h#newcode25 third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h:25: class WorkletGlobalScope : public RefCountedWillBeGarbageCollectedFinalized<WorkletGlobalScope>, public SecurityContext, public MainThreadWorkletGlobalScope, ...
4 years, 9 months ago (2016-03-11 22:34:25 UTC) #4
ikilpatrick
https://codereview.chromium.org/1745253002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h File third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h (right): https://codereview.chromium.org/1745253002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h#newcode25 third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h:25: class WorkletGlobalScope : public RefCountedWillBeGarbageCollectedFinalized<WorkletGlobalScope>, public SecurityContext, public MainThreadWorkletGlobalScope, ...
4 years, 9 months ago (2016-03-11 23:37:09 UTC) #5
pfeldman
https://codereview.chromium.org/1745253002/diff/80001/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp (right): https://codereview.chromium.org/1745253002/diff/80001/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp#newcode178 third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp:178: if (context->isWorkletGlobalScope()) { Is this only used for the ...
4 years, 9 months ago (2016-03-15 00:34:56 UTC) #6
ikilpatrick
Sorry for the slow response, working on LayoutNG things. Just did a rebase to move ...
4 years, 9 months ago (2016-03-17 16:46:44 UTC) #7
pfeldman
lgtm
4 years, 9 months ago (2016-03-17 18:53:48 UTC) #8
kinuko
Are test breaks unrelated? lgtm/2 for the code changes
4 years, 9 months ago (2016-03-18 08:58:12 UTC) #9
ikilpatrick
On 2016/03/18 08:58:12, kinuko wrote: > Are test breaks unrelated? lgtm/2 for the code changes ...
4 years, 9 months ago (2016-03-18 18:13:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745253002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745253002/140001
4 years, 9 months ago (2016-03-18 18:15:21 UTC) #13
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 9 months ago (2016-03-18 19:11:52 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 19:13:11 UTC) #17
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/9cdec5a9343fbba9ed72531696a3f4e06ebf4b6e
Cr-Commit-Position: refs/heads/master@{#382040}

Powered by Google App Engine
This is Rietveld 408576698